Skip to content

Fixes implicit dropping of unseen target levels in SMOTE-like PipeOps #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jun 2, 2025

Conversation

advieser
Copy link
Collaborator

closes #881

@mb706 mb706 mentioned this pull request Mar 31, 2025
@advieser
Copy link
Collaborator Author

advieser commented May 14, 2025

Concerning the empty target levels, we decided to drop them in PipeOpSmoteNC from the themis package as well to have consistent behavior, i.e. dropping empty target levels instead throwing an error (which themis would do itself otherwise).
Side note: The other PipeOp from themis, PipeOpTomek, only down-samples. Because of this, there is no error for empty target levels in themis. Additionally, it does not modify the task internally, so no fix is needed.

@advieser advieser marked this pull request as ready for review May 14, 2025 17:48
@advieser advieser changed the title Handle errors in smotefamily PipeOps Fixes implicit dropping of unseen target levels in SMOTE-like PipeOps May 14, 2025
@advieser advieser merged commit 9490408 into master Jun 2, 2025
4 checks passed
@advieser advieser deleted the catch_smotefamily_errors branch June 2, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Obscure errors in smotefamily PipeOps due to unobserved factor levels
1 participant