Skip to content

Conversation

m-muecke
Copy link
Member

@mb706 check if you want/like this, this standardises to use more ps$set_values() like in the other mlr3 packages

@m-muecke m-muecke requested a review from mb706 March 29, 2025 15:39
@mb706
Copy link
Collaborator

mb706 commented Apr 8, 2025

conflicted about this; the point of $values = list() is that the previous state of $values is overwritten. $set_values() does not change values that are already set; even if it does the same thing, the information that there is no relevant previous state is lost. In reality, we should probably use the init = functionality of the new paradox syntax. Will leave this open for now and think about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants