Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dedicated process mode to ParallelExecutionRunnable #552

Merged
merged 4 commits into from
Jan 26, 2025

Conversation

gtopper
Copy link
Collaborator

@gtopper gtopper commented Dec 23, 2024

To avoid serialization of the runnable per event, and to allow the user to allocate resources specific to that runnable (e.g. GPUs).

To avoid serialization of the runnable per event, and to allow the user to allocate resources specific to that runnable (e.g. GPUs).
@gtopper gtopper requested a review from assaf758 December 23, 2024 11:07
@gtopper
Copy link
Collaborator Author

gtopper commented Dec 26, 2024

After talking to @GiladShapira94, the plan is to keep the original process pool mode and add an addition sticky process mode (one-to-one for now, perhaps one-to-many in the future).

@gtopper gtopper marked this pull request as draft December 30, 2024 11:15
@gtopper gtopper marked this pull request as ready for review January 9, 2025 11:24
@gtopper gtopper changed the title Create one process per ParallelExecutionRunnable Add dedicated process mode to ParallelExecutionRunnable Jan 9, 2025
Copy link
Member

@assaf758 assaf758 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One comment inline.

tests/test_flow.py Show resolved Hide resolved
@gtopper gtopper requested a review from assaf758 January 26, 2025 11:37
@gtopper gtopper merged commit 0e49baf into mlrun:development Jan 26, 2025
3 checks passed
gtopper added a commit to gtopper/mlrun that referenced this pull request Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants