Skip to content

Commit

Permalink
QA Sprint 150 done (#2075)
Browse files Browse the repository at this point in the history
Collecting PRs into branch development from branch tests:

* Update ts for HUB functions in Batch Run
- Categories mapping in "Filter by category" of HUB functions in Batch Run
- Jira: ML-4677
- "Batch-inference" is not shown among Hub functions in Function Selection section of Batch Run
- Jira: ML-4580
- "Apply" button in "Filter by category" of HUB functions in Batch Run
- Jira: ML-4294ests for HUB functions in Batch Run
- Categories mapping in "Filter by category" of HUB functions in Batch Run
- Jira: ML-4677
- "Batch-inference" is not shown among Hub functions in Function Selection section of Batch Run
- Jira: ML-4580
- "Apply" button in "Filter by category" of HUB functions in Batch Run
- Jira: ML-4294

* Create test for Feature Store
- Check type Redis in online types of Target Store section of Create Set
- Jira: ML-4066, ML-4277

* Updated tests for Datasets
- UI changes  according to Figma new design (register button, download icon)
- Jira: ML-3984, ML-4215

---------

Co-authored-by: EZheln <36635708+EZheln@users.noreply.github.com>
Co-authored-by: Olena Zhelnytska <olena.zhelnytska@medtronic.com>
  • Loading branch information
3 people authored Nov 14, 2023
1 parent c10a5fd commit 2f6fc03
Show file tree
Hide file tree
Showing 11 changed files with 191 additions and 109 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@
"body-parser": "^1.19.0",
"case-sensitive-paths-webpack-plugin": "^2.4.0",
"chai": "^4.3.4",
"chromedriver": "^117.0.0",
"chromedriver": "^119.0.0",
"crypto": "^1.0.1",
"css-loader": "^6.5.1",
"cucumber-html-reporter": "^5.3.0",
Expand Down
24 changes: 13 additions & 11 deletions tests/features/common-tools/common-consts.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,17 +87,18 @@ module.exports = {
},
Datasets_Info_Pane: {
Tab_List: ['Overview', 'Preview', 'Metadata', 'Analysis'],
Action_Menu_List: ['Download', 'Copy URI', 'View YAML', 'Add a tag'],
Overview_General_Headers: [
'Hash',
'Key',
'Version tag',
'Iter',
'Size',
'Path',
'URI',
'UID',
'Updated',
'Labels'
'Hash:',
'Key:',
'Version tag:',
'Iter:',
'Size:',
'Path:',
'URI:',
'UID:',
'Updated:',
'Labels:'
]
},
ML_Functions_Tab: {
Expand Down Expand Up @@ -201,7 +202,8 @@ module.exports = {
Data_Inputs_Table_Header: ['Input name', 'Path'],
Parameters_Table_Header: ['Name', 'Type', 'Value'],
Parameters_Table_Header_Hyper: ['Hyper','Name', 'Type', 'Value'],
Image_Name_Text: 'The image must include all the software packages that are required to run the function. For example, for an XGBoost model, ensure that the image includes the correct XGboost package and version'
Image_Name_Text: 'The image must include all the software packages that are required to run the function. For example, for an XGBoost model, ensure that the image includes the correct XGboost package and version',
Hub_Filter_Category: ['Data Preparation', 'Machine Learning', 'Other', 'Data Analysis', 'Feature Store', 'Model Serving', 'Model Training', 'Monitoring', 'Model Testing', 'ETL', 'Data Validation'],
},
Batch_Inference: {
Model_Path_Type_Store: ['MLRun store']
Expand Down
2 changes: 1 addition & 1 deletion tests/features/common/actions/api.actions.js
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ const action = {
kind: 'api',
uri: 'localhost:3000'
},
target_path:{}
target_path:''
},
status: {},
uid: uid
Expand Down
14 changes: 10 additions & 4 deletions tests/features/common/page-objects/feature-store.po.js
Original file line number Diff line number Diff line change
Expand Up @@ -298,12 +298,18 @@ const datasetsTable = {
owner: '.table-body__cell:nth-of-type(4) .data-ellipsis',
uploaded: '.table-body__cell:nth-of-type(5) .data-ellipsis',
size: '.table-body__cell:nth-of-type(6) .data-ellipsis',
artifact_preview_btn: '.table-body__cell:nth-of-type(7) button',
artifact_preview_btn: '.table-body__cell:nth-of-type(7) #quick-link-dataset-preview',
download_btn: '.table-body__cell:nth-of-type(8) .download-container',
copy_uri: '.table-body__cell:nth-of-type(9) > button',
action_menu: {
componentType: actionMenu,
structure: actionMenuStructure
structure: {
root: '.actions-menu__container',
menuElements: {
open_button: '[data-testid="actions-menu"] button',
options: '.actions-menu__body .actions-menu__option'
}
}
}
}
}
Expand Down Expand Up @@ -385,11 +391,11 @@ module.exports = {
},
datasets: {
Feature_Store_Tab_Selector: featureStoreTabSelector,
Register_Dataset_Button: pageHeaderButton,
Register_Dataset_Button: By.css('.content__action-bar-wrapper .action-bar__actions .register-button'),
Table_Name_Filter_Input: commonNameFilterInputDataset,
Table_FilterBy_Button: tableFilterByButton,
Table_Refresh_Button: tableRefreshButton,
Datasets_Table: commonTable(datasetsTable),
Datasets_Table: commonTable(datasetsTable)
},
addToFeatureVector: {
Table_Tree_Filter_Dropdown: commonTableTreeFilterDropdown,
Expand Down
3 changes: 2 additions & 1 deletion tests/features/common/page-objects/jobs-and-workflows.po.js
Original file line number Diff line number Diff line change
Expand Up @@ -766,7 +766,8 @@ module.exports = {
Checkbox_Category_Selector: commonTable(checkboxCategorySelector),
Filter_Dropdown: {
Title: By.css('.hub-filter h3.filters-wizard__header'),
Clear_Button: By.css('.hub-filter .filters-wizard__modal-buttons button')
Clear_Button: By.css('.hub-filter .filters-wizard__modal-buttons .btn-tertiary'),
Apply_Button: By.css('.hub-filter .filters-wizard__modal-buttons .btn-secondary')
},
Filter_Button_Hub_Tab: By.css('.hub-tab .form-row .filters-button button'),
Functions_Table: commonTable(functionsTableSelector),
Expand Down
7 changes: 7 additions & 0 deletions tests/features/common/page-objects/side-panel.po.js
Original file line number Diff line number Diff line change
Expand Up @@ -811,6 +811,13 @@ module.exports = {
Online_Checkbox_State: By.css(
'.feature-set-panel .accordion__container:nth-of-type(3) .accordion__body .target-store__item:nth-of-type(1) .checkbox'
),
NOSQL_Kind_Dropdown: dropdownComponent(
generateDropdownGroup(
'.target-store__inputs-container .select-medium',
'.select__header',
'.select__options-list .select__item'
)
),
Offline_Partition_Checkbox_State: By.css(
'.feature-set-panel .accordion__container:nth-of-type(3) .panel-section__body .target-store__item:nth-of-type(2) .target-store__inputs-container .checkbox'
),
Expand Down
75 changes: 46 additions & 29 deletions tests/features/datasets.feature
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
Feature: Datasets Page

Testcases that verifies functionality on Datasets Page


@MLD
@passive
Scenario: MLD001 - Check all mandatory components on Datasets page
Given open url
Expand All @@ -18,7 +19,7 @@ Feature: Datasets Page
Then verify breadcrumbs "tab" label should be equal "Datasets" value
And wait load page
Then verify "Register_Dataset_Button" element visibility on "Datasets" wizard
Then "Register_Dataset_Button" element on "Datasets" should contains "Register Dataset" value
Then "Register_Dataset_Button" element on "Datasets" should contains "Register dataset" value
Then verify "Table_Name_Filter_Input" element visibility on "Datasets" wizard
Then verify "Table_FilterBy_Button" element visibility on "Datasets" wizard
Then click on "Table_FilterBy_Button" element on "Datasets" wizard
Expand All @@ -34,6 +35,7 @@ Feature: Datasets Page
Then verify "Table_Refresh_Button" element visibility on "Datasets" wizard
Then verify "Datasets_Table" element visibility on "Datasets" wizard

@MLD
@passive
Scenario: MLD002 - Verify behaviour of Show iterations checkbox on Datasets page
Given open url
Expand Down Expand Up @@ -64,8 +66,8 @@ Feature: Datasets Page
Then "Show_Iterations_Checkbox" element should be checked on "Artifacts_FilterBy_Popup" wizard
Then check "expand_btn" not presented in "Datasets_Table" on "Datasets" wizard

@MLD
@passive
@inProgress
Scenario: MLD003 - Check all mandatory components in Item infopane on Overview tab table on Datasets page
Given open url
And wait load page
Expand All @@ -79,8 +81,8 @@ Feature: Datasets Page
Then verify "Overview" tab is active in "Info_Pane_Tab_Selector" on "Datasets_Info_Pane" wizard
Then verify "Header" element visibility on "Datasets_Info_Pane" wizard
Then verify "Updated" element visibility on "Datasets_Info_Pane" wizard
Then verify "Download_Button" element visibility on "Datasets_Info_Pane" wizard
Then verify "Action_Menu" element visibility on "Datasets_Info_Pane" wizard
Then verify "Action_Menu" dropdown element on "Datasets_Info_Pane" wizard should contains "Datasets_Info_Pane"."Action_Menu_List"
Then verify "Full_View_Button" element visibility on "Datasets_Info_Pane" wizard
Then verify "Cross_Close_Button" element visibility on "Datasets_Info_Pane" wizard
Then verify "Overview_General_Headers" on "Datasets_Info_Pane" wizard should contains "Datasets_Info_Pane"."Overview_General_Headers"
Expand All @@ -91,7 +93,8 @@ Feature: Datasets Page
Then verify "Cross_Close_Button" element not exists on "Datasets_Info_Pane" wizard
Then click on "Tabel_View_Button" element on "Datasets_Info_Pane" wizard
Then verify "Cross_Close_Button" element visibility on "Datasets_Info_Pane" wizard


@MLD
@passive
Scenario: MLD005 - Check Details panel still active on page refresh
* set tear-down property "dataset" created in "automation-test" project with "test-file" value
Expand All @@ -116,7 +119,8 @@ Feature: Datasets Page
Then refresh a page
Then verify "Header" element visibility on "Datasets_Info_Pane" wizard
Then "Header" element on "Datasets_Info_Pane" should contains "test-dataset" value


@MLD
@passive
Scenario: MLD006 - Check all mandatory components on Register Dataset form
Given open url
Expand All @@ -127,7 +131,7 @@ Feature: Datasets Page
And wait load page
And select "tab" with "Datasets" value in breadcrumbs menu
And wait load page
Then "Register_Dataset_Button" element on "Datasets" should contains "Register Dataset" value
Then "Register_Dataset_Button" element on "Datasets" should contains "Register dataset" value
Then click on "Register_Dataset_Button" element on "Datasets" wizard
Then verify if "Register_Dataset" popup dialog appears
Then navigate back
Expand Down Expand Up @@ -190,12 +194,16 @@ Feature: Datasets Page
Then verify "Title" element not exists on "Register_Dataset" wizard
Then navigate forward
Then verify "Title" element not exists on "Register_Dataset" wizard


@MLD
@FAILED_TODO
#TODO: requires a separate run
Scenario: MLD007 - Verify behaviour on Register new Dataset
* set tear-down property "dataset" created in "default" project with "test-dataset" value
Given open url
And wait load page
And click on row root with value "default" in "name" column in "Projects_Table" table on "Projects" wizard
And wait load page
And hover "Project_Navigation_Toggler" component on "commonPagesHeader" wizard
And click on cell with value "Datasets" in "link" column in "General_Info_Quick_Links" table on "commonPagesHeader" wizard
And wait load page
Expand All @@ -212,9 +220,10 @@ Feature: Datasets Page
Then check "test-dataset" value in "key" column in "Overview_Table" table on "Datasets_Info_Pane" wizard
Then check "latest" value in "tag" column in "Overview_Table" table on "Datasets_Info_Pane" wizard
Then check "v3io:///target/path" value in "path" column in "Overview_Table" table on "Datasets_Info_Pane" wizard


@MLD
@passive
Scenario: Check filtering by name on Datasets page
Scenario: MLD014 - Check filtering by name on Datasets page
Given open url
And click on row root with value "churn-project-admin" in "name" column in "Projects_Table" table on "Projects" wizard
And wait load page
Expand All @@ -227,7 +236,8 @@ Feature: Datasets Page
Then click on "Table_Refresh_Button" element on "Datasets" wizard
And wait load page
Then value in "name" column with "text" in "Datasets_Table" on "Datasets" wizard should contains "ea"


@MLD
@passive
Scenario: MLD004 - Verify filtering by label on Datasets page
Given open url
Expand Down Expand Up @@ -255,9 +265,10 @@ Feature: Datasets Page
And wait load page
And verify "No_Data_Message" element visibility on "commonPagesHeader" wizard
Then "No_Data_Message" component on "commonPagesHeader" should contains "No_Data_Message"."No_Datasets_data"


@MLD
@passive
Scenario: Verify View YAML action on Datasets page
Scenario: MLD015 - Verify View YAML action on Datasets page
Given open url
And wait load page
And click on row root with value "churn-project-admin" in "name" column in "Projects_Table" table on "Projects" wizard
Expand All @@ -281,28 +292,27 @@ Feature: Datasets Page
Then verify if "View_YAML" popup dialog appears
Then verify "Cross_Cancel_Button" element visibility on "View_YAML" wizard
Then verify "YAML_Modal_Container" element visibility on "View_YAML" wizard

@FAILED_TODO
#TODO: 'artifact_preview_btn' is disabled so error with element visibility 'Preview_Header'

@MLD
@passive
Scenario: Check all mandatory components on Artifact Preview on Datasets page
Scenario: MLD013 - Check components on Artifact Preview on Datasets page
Given open url
And wait load page
And click on row root with value "churn-project-admin" in "name" column in "Projects_Table" table on "Projects" wizard
And wait load page
And hover "Project_Navigation_Toggler" component on "commonPagesHeader" wizard
Then click on "Project_Monitoring_Button" element on "commonPagesHeader" wizard
And click on row root with value "default" in "name" column in "Projects_Table" table on "Projects" wizard
And wait load page
And select "tab" with "Datasets" value in breadcrumbs menu
And wait load page
Then hover on cell with row index 2 in "name" column in "Datasets_Table" table on "Datasets" wizard
When click on cell with row index 2 in "artifact_preview_btn" column in "Datasets_Table" table on "Datasets" wizard
And wait load page
When click on cell with row index 1 in "artifact_preview_btn" column in "Datasets_Table" table on "Datasets" wizard
Then verify "Preview_Header" element visibility on "Artifact_Preview_Popup" wizard
Then verify "Cross_Cancel_Button" element visibility on "Artifact_Preview_Popup" wizard


@MLD
@FAILED_TODO
#TODO: Redirection - ML-4600
#TODO: url without iter number, doesn't send in new artifacts structure
Scenario: Check broken link redirection
#TODO: Redirection - ML-4600, url without iter number, doesn't send in new artifacts structure
#TODO: requires a separate run
Scenario: MLD016 - Check broken link redirection
* set tear-down property "dataset" created in "default" project with "test_ds" value
* create "test_ds" Dataset with "latest" tag in "default" project with code 200
Given open url
Expand All @@ -324,8 +334,9 @@ Feature: Datasets Page
Then verify redirection from "projects/default/datasets/test_ds/latest/0/INVALID" to "projects/default/datasets/test_ds/latest/0/overview"
Then verify redirection from "projects/INVALID/datasets/test_ds/latest/0/overview" to "projects"
Then verify redirection from "projects/default/INVALID/test_ds/latest/0/overview" to "projects"

Scenario: Check active/highlited items with details panel on Datasets

@MLD
Scenario: MLD017 - Check active/highlited items with details panel on Datasets
Given open url
And wait load page
And click on row root with value "churn-project-admin" in "name" column in "Projects_Table" table on "Projects" wizard
Expand All @@ -349,7 +360,8 @@ Feature: Datasets Page
Then verify "Header" element visibility on "Datasets_Info_Pane" wizard
Then save to context "name" column on 2 row from "Datasets_Table" table on "Datasets" wizard
Then compare "Header" element value on "Datasets_Info_Pane" wizard with test "name" context value


@MLD
Scenario: MLD009 - Check that version tag is filled when edit it in table view and full view on Overview tab table on Datasets page
Given open url
And wait load page
Expand All @@ -373,6 +385,7 @@ Feature: Datasets Page
Then click on "Tabel_View_Button" element on "Datasets_Info_Pane" wizard
Then verify "Cross_Close_Button" element visibility on "Datasets_Info_Pane" wizard

@MLD
Scenario: MLD010 - Check that version tag dropdown shows all tags on filters wizard on Datasets page
Given open url
And wait load page
Expand All @@ -399,6 +412,7 @@ Scenario: MLD010 - Check that version tag dropdown shows all tags on filters wiz
And wait load page
Then check "newTag" value in "tag" column in "Datasets_Table" table on "Datasets" wizard

@MLD
Scenario: MLD011 - Check that version tag has "Click to add" status when it's empty after edited
Given open url
And wait load page
Expand All @@ -425,6 +439,9 @@ Scenario: MLD011 - Check that version tag has "Click to add" status when it's em
And wait load page
Then "Version_Tag_Input_Placeholder" element on "Datasets_Info_Pane" should contains "Click to add" value

@MLD
@FAILED_TODO
#TODO: requires a separate run
Scenario: MLD012 - Check filter by "All" tag is performed when version tag was edited
Given open url
And wait load page
Expand Down
23 changes: 22 additions & 1 deletion tests/features/featureStore.feature
Original file line number Diff line number Diff line change
Expand Up @@ -1991,4 +1991,25 @@ Feature: Feature Store Page
Then select "Delete" option in action menu on "Projects" wizard in "Projects_Table" table at row with "automation-test-name201" value in "name" column
Then verify if "Common_Popup" popup dialog appears
Then click on "Delete_Button" element on "Common_Popup" wizard
Then check "automation-test-name201" value not in "name" column in "Projects_Table" table on "Projects" wizard
Then check "automation-test-name201" value not in "name" column in "Projects_Table" table on "Projects" wizard

Scenario: MLFS059 - Check type Redis in online types of Target Store section of Create Set
Given open url
And wait load page
And click on row root with value "churn-project-admin" in "name" column in "Projects_Table" table on "Projects" wizard
And wait load page
And hover "Project_Navigation_Toggler" component on "commonPagesHeader" wizard
And click on cell with value "Feature store" in "link" column in "General_Info_Quick_Links" table on "commonPagesHeader" wizard
And wait load page
And verify "Feature_Store_Tab_Selector" on "Feature_Store_Feature_Sets_Tab" wizard should contains "Feature_Store"."Tab_List"
And verify "Feature Sets" tab is active in "Feature_Store_Tab_Selector" on "Feature_Store_Feature_Sets_Tab" wizard
And click on "Create_Set_Button" element on "Feature_Store_Feature_Sets_Tab" wizard
Then type value "test-fs1" to "Feature_Set_Name_Input" field on "New_Feature_Set" wizard
Then click on "Accordion_Header" element in "Target_Store_Accordion" on "New_Feature_Set" wizard
When check "Online_Checkbox" element in "Target_Store_Accordion" on "New_Feature_Set" wizard
Then "Online_Path" element in "Target_Store_Accordion" on "New_Feature_Set" should contains "v3io:///projects/churn-project-admin/FeatureStore/test-fs1/nosql/sets/test-fs1" value
Then click on "Edit_Online_Path_Button" element in "Target_Store_Accordion" on "New_Feature_Set" wizard
Then select "REDIS" option in "NOSQL_Kind_Dropdown" dropdown on "New_Feature_Set" wizard
And wait load page
Then click on "Apply_Online_Path_Button" element in "Target_Store_Accordion" on "New_Feature_Set" wizard
Then "Online_Path" element in "Target_Store_Accordion" on "New_Feature_Set" should contains "redis://{authority}/projects/churn-project-admin/FeatureStore/test-fs1/redisnosql/sets/test-fs1" value
Loading

0 comments on commit 2f6fc03

Please sign in to comment.