Skip to content

Commit

Permalink
Fix [Project monitoring] misleading artifacts counter in project moni…
Browse files Browse the repository at this point in the history
…toring screen (#2213)
  • Loading branch information
Taras-Hlukhovetskyi authored Jan 22, 2024
1 parent 1280b05 commit 7e11615
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 8 deletions.
3 changes: 3 additions & 0 deletions src/components/Project/ProjectMonitorView.js
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,9 @@ const ProjectMonitorView = ({
counterValue={projectSummary.data.files_count ?? 0}
link={`/projects/${params.projectName}/files`}
projectSummary={projectSummary}
tip="This counter is the number of artifacts with different names (keys).
Each such artifact may have many versions, produced by multiple runs and given multiple tags.
You can browse them in the Artifacts page."
title="Artifacts"
/>
{nuclioStreamsAreEnabled && (
Expand Down
14 changes: 6 additions & 8 deletions src/elements/ProjectSummaryCard/ProjectSummaryCard.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,9 @@ import { Link } from 'react-router-dom'
import PropTypes from 'prop-types'

import Loader from '../../common/Loader/Loader'
import { Tooltip, TextTooltipTemplate } from 'igz-controls/components'
import { Tip, Tooltip, TextTooltipTemplate } from 'igz-controls/components'

const ProjectSummaryCard = ({
counterValue,
link,
projectSummary,
title,
tooltipText
}) => {
const ProjectSummaryCard = ({ counterValue, link, projectSummary, tip, title, tooltipText }) => {
return (
<Link to={link} className="project-data-card project-data-card_small">
<Tooltip
Expand All @@ -41,6 +35,7 @@ const ProjectSummaryCard = ({
<div className="project-data-card__header">
<div className="project-data-card__header-text data-ellipsis">
{title}
{tip && <Tip className="checkbox__label-tip" text={tip} />}
</div>
<div className="project-data-card__statistics">
<div className="project-data-card__statistics-item">
Expand All @@ -60,14 +55,17 @@ const ProjectSummaryCard = ({
}

ProjectSummaryCard.defaultProps = {
tip: null,
tooltipText: null

}

ProjectSummaryCard.propTypes = {
counterValue: PropTypes.oneOfType([PropTypes.string, PropTypes.number])
.isRequired,
link: PropTypes.string.isRequired,
projectSummary: PropTypes.object.isRequired,
tip: PropTypes.string,
title: PropTypes.string.isRequired,
tooltipText: PropTypes.string
}
Expand Down

0 comments on commit 7e11615

Please sign in to comment.