Fix [Functions panel] Show "Volumes" dropdown on function edit

mlrun · Nov 17, 2023 · c2094a2 · c2094a2
1 parent c10a5fd
commit c2094a2
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/src/elements/FunctionsPanelResources/FunctionsPanelResources.js b/src/elements/FunctionsPanelResources/FunctionsPanelResources.js
@@ -89,6 +89,7 @@ const FunctionsPanelResources = ({
   ])
 
   const [data, setData] = useState({
+    disable_auto_mount: defaultData.disable_auto_mount ?? true,
     volumeMounts: getDefaultVolumeMounts(
       defaultData.volume_mounts ?? [],
       defaultData.volumes ?? [],

diff --git a/src/elements/FunctionsPanelResources/FunctionsPanelResourcesView.js b/src/elements/FunctionsPanelResources/FunctionsPanelResourcesView.js
@@ -82,10 +82,11 @@ const FunctionsPanelResourcesView = ({
         title="Volumes"
         tip="Volumes that define data paths and the required information for accessing the data from the function"
       >
-        {mode === PANEL_CREATE_MODE && (
+        {(mode === PANEL_CREATE_MODE || !data.disable_auto_mount) && (
           <Select
             className="volume-mount"
             floatingLabel
+            disabled={mode !== PANEL_CREATE_MODE}
             label="Volume mount"
             options={volumeMountOptions}
             onClick={handleSelectVolumeMount}

diff --git a/src/utils/parseFunction.js b/src/utils/parseFunction.js
@@ -32,6 +32,7 @@ export const parseFunction = (func, projectName, customState) => {
     default_class: func.spec?.default_class ?? '',
     default_handler: func.spec?.default_handler ?? '',
     description: func.spec?.description ?? '',
+    disable_auto_mount: func.spec?.disable_auto_mount ?? true,
     env: func.spec?.env ?? [],
     error_stream: func.spec?.error_stream ?? '',
     graph: func.spec?.graph ?? {},