Fix by code review

mlrun · Nov 30, 2023 · eec48a4 · eec48a4
1 parent b9e7ad8
commit eec48a4
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 12 deletions.
diff --git a/src/common/Input/Input.js b/src/common/Input/Input.js
@@ -337,6 +337,7 @@ Input.defaultProps = {
   focused: false,
   iconClass: '',
   iconOnClick: () => { },
+  id: '',
   infoLabel: false,
   inputIcon: null,
   invalid: false,

diff --git a/src/components/JobWizard/JobWizard.js b/src/components/JobWizard/JobWizard.js
@@ -422,14 +422,7 @@ const JobWizard = ({
           ref: scheduleButtonRef
         },
         {
-          id:
-            mode === PANEL_EDIT_MODE
-              ? 'job-wizard-btn-save'
-              : isBatchInference
-              ? 'job-wizard-btn-infer-now'
-              : isTrain
-              ? 'job-wizard-btn-run-training'
-              : 'job-wizard-btn-run',
+          id:'run-btn',
           label:
             mode === PANEL_EDIT_MODE
               ? 'Save'

diff --git a/src/components/JobWizard/JobWizardSteps/JobWizardDataInputs/JobWizardDataInputs.js b/src/components/JobWizard/JobWizardSteps/JobWizardDataInputs/JobWizardDataInputs.js
@@ -35,7 +35,6 @@ const JobWizardDataInputs = ({ formState, stepIsActive }) => {
           exitEditModeTriggerItem={stepIsActive}
           fieldsPath={`${DATA_INPUTS_STEP}.dataInputsTable`}
           formState={formState}
-          id="data-inputs-form-table"
           rowCanBeAdded={formState.values.runDetails.handlerData?.has_kwargs}
         />
       </div>

diff --git a/src/components/JobWizard/JobWizardSteps/JobWizardResources/JobWizardResources.js b/src/components/JobWizard/JobWizardSteps/JobWizardResources/JobWizardResources.js
@@ -88,7 +88,6 @@ const JobWizardResources = ({ formState, frontendSpec, stepIsActive }) => {
           exitEditModeTriggerItem={stepIsActive}
           fieldsPath={`${RESOURCES_STEP}.volumesTable`}
           formState={formState}
-          id="add-volumes-form-table"
         />
       </div>
     </div>

diff --git a/src/elements/FormDataInputsTable/FormDataInputsTable.js b/src/elements/FormDataInputsTable/FormDataInputsTable.js
@@ -153,7 +153,7 @@ const FormDataInputsTable = ({
 FormDataInputsTable.defaultProps = {
   className: '',
   disabled: false,
-  id: 'data-inputs-table',
+  id: 'data-inputs-form-table',
   exitEditModeTriggerItem: null,
   rowCanBeAdded: false
 }

diff --git a/src/elements/FormVolumesTable/FormVolumesTable.js b/src/elements/FormVolumesTable/FormVolumesTable.js
@@ -113,7 +113,7 @@ const FormVolumesTable = ({ disabled, exitEditModeTriggerItem, fieldsPath, formS
 FormVolumesTable.defaultProps = {
   disabled: false,
   exitEditModeTriggerItem: null,
-  id: 'volumes-table'
+  id: 'volumes-form-table'
 }
 
 FormVolumesTable.propTypes = {