Fix [Jobs] log is being duplicated upon refresh

mlrun · Jan 9, 2024 · f01a60a · f01a60a
1 parent 661475b
commit f01a60a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/components/DetailsLogs/DetailsLogs.js b/src/components/DetailsLogs/DetailsLogs.js
@@ -50,7 +50,10 @@ const DetailsLogs = ({
   }, [item, params.projectName, refreshLogs, removeLogs, withLogsRefreshBtn])
 
   const handleScroll = event => {
-    if (streamLogsRef.current && event.target.scrollHeight - event.target.scrollTop === event.target.clientHeight) {
+    if (
+      streamLogsRef.current &&
+      event.target.scrollHeight - event.target.scrollTop - 1 < event.target.clientHeight
+    ) {
       streamLogsRef.current()
     }
   }

diff --git a/src/utils/getJobLogs.util.js b/src/utils/getJobLogs.util.js
@@ -18,6 +18,8 @@ under the Apache 2.0 license is conditioned upon your compliance with
 such restriction.
 */
 export const getJobLogs = (uid, projectName, streamLogsRef, setDetailsLogs, fetchJobLogs) => {
+  setDetailsLogs('')
+
   fetchJobLogs(uid, projectName).then(res => {
     const reader = res.body?.getReader()