Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [Feature Store] Capitalize the first letter of the sentence in the Schema description. #2081

Merged
merged 2 commits into from
Nov 18, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,11 @@ const FeatureSetsPanelSchemaView = ({
<FeatureSetsPanelSection title="Schema">
<div className="schema__description">
<span>
Each feature set must be associated with one or more index column.
when joining feature sets the entity is used as the key column.
Each feature set must be associated with one or more index column. When joining feature
sets, the entity is used as the key column.
</span>
<span>
&nbsp;
<a
className="link"
href="https://docs.mlrun.org/en/latest/feature-store/feature-sets.html"
Expand Down Expand Up @@ -75,14 +78,9 @@ const FeatureSetsPanelSchemaView = ({
floatingLabel
invalid={!validation.isTimestampKeyValid}
label="Timestamp key"
onChange={timestamp_key =>
setData(state => ({ ...state, timestamp_key }))
}
onChange={timestamp_key => setData(state => ({ ...state, timestamp_key }))}
onBlur={event => {
if (
featureStore.newFeatureSet.spec.timestamp_key !==
event.target.value
) {
if (featureStore.newFeatureSet.spec.timestamp_key !== event.target.value) {
setNewFeatureSetSchemaTimestampKey(event.target.value)
}
}}
Expand Down