Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [UI] add the 'data-testid' for 'Add volume' and 'Add node selector' buttons #2087

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Fix [UI] add the 'data-testid' for 'Add volume' and 'Add node selector' buttons #2087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99ba18b
Fix [UI] add the 'data-testid' for 'Add volume' and 'Add node selecto…
ilan7empest Nov 18, 2023
dc3f3ee
fix by code review
ilan7empest Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/JobWizard/JobWizardSteps/JobWizardResources/JobWizardResources.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ const JobWizardResources = ({ formState, frontendSpec, stepIsActive }) => {
<div className="form-row form-table-title">Node selection</div>
<div className="form-row">
<FormKeyValueTable
actionButtonId="add-node-selector"
addNewItemLabel="Add node selector"
exitEditModeTriggerItem={stepIsActive}
fieldsPath={`${RESOURCES_STEP}.nodeSelectorTable`}
Expand Down
3 changes: 2 additions & 1 deletion src/elements/FormVolumesTable/FormVolumesTable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ const FormVolumesTable = ({ disabled, exitEditModeTriggerItem, fieldsPath, formS
hidden={editingItem?.ui?.isNew}
fields={fields}
fieldsPath={fieldsPath}
id="add-volume"
label="Add volume"
onClick={(...addRowArgs) =>
addNewRow(...addRowArgs, {
Expand All @@ -111,7 +112,7 @@ const FormVolumesTable = ({ disabled, exitEditModeTriggerItem, fieldsPath, formS

FormVolumesTable.defaultProps = {
disabled: false,
exitEditModeTriggerItem: null,
exitEditModeTriggerItem: null
}

FormVolumesTable.propTypes = {
Expand Down