Skip to content

Fix [Project monitoring] misleading artifacts counter in project monitoring screen #2217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilan7empest merged 1 commit into from
Jan 24, 2024
Merged

Fix [Project monitoring] misleading artifacts counter in project monitoring screen #2217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/components/Project/ProjectMonitorView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,9 @@ const ProjectMonitorView = ({
counterValue={projectSummary.data.models_count ?? 0}
link={`/projects/${params.projectName}/models`}
projectSummary={projectSummary}
tip="This counter is the number of models with different names (keys).
Each such model may have many versions, produced by multiple runs and given multiple tags.
You can browse them in the Models page."
title="Models"
/>
<ProjectSummaryCard
Expand Down
4 changes: 4 additions & 0 deletions src/components/Project/project.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,10 @@
line-height: 23px;
}

&-tip {
margin-left: 5px;
}

&.table-header {
min-height: 180px;
}
Expand Down
2 changes: 1 addition & 1 deletion src/elements/ProjectSummaryCard/ProjectSummaryCard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const ProjectSummaryCard = ({ counterValue, link, projectSummary, tip, title, to
<div className="project-data-card__header">
<div className="project-data-card__header-text data-ellipsis">
{title}
{tip && <Tip className="checkbox__label-tip" text={tip} />}
{tip && <Tip className="project-data-card__header-tip" text={tip} />}
</div>
<div className="project-data-card__statistics">
<div className="project-data-card__statistics-item">
Expand Down