Skip to content

Commit

Permalink
Merge pull request #137 from mlsecproject/release-0.1.3
Browse files Browse the repository at this point in the history
Release 0.1.3
  • Loading branch information
alexcpsec committed Apr 27, 2015
2 parents 4f41484 + a2dcb7e commit b8794f2
Show file tree
Hide file tree
Showing 7 changed files with 12,692 additions and 10,272 deletions.
5 changes: 4 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,20 @@
CHANGE LOG
==========

#### Future Release
#### 0.1.3 Captivating Capybara
Bugfix release, and also making it easier to install and use the system with Venv and Docker procedures. Special thanks to [@krmaxwell](https://github.com/krmaxwell) who seems to have done all the work

* Updating the regex used for hostname capture on Thresher. Will be further updated on v0.2 ([#131](https://github.com/mlsecproject/combine/issues/131))
* Sources update:
* Updating PalevoTracker location and removing Spyeye tracker ([#123](https://github.com/mlsecproject/combine/issues/123))
* Updating MaxMind local dataset to March 2015
* Adding Feodo Abuse.ch tracker
* Ajusted Wiki to current Threat Intelligence feeds ([#71](https://github.com/mlsecproject/combine/issues/71))
* Docker file and usage guide ([#117](https://github.com/mlsecproject/combine/issues/117))
* Instalation documentation using Python venv ([#115](https://github.com/mlsecproject/combine/issues/115))
* Minor cleanup on gitignore and other files ([#109](https://github.com/mlsecproject/combine/issues/109))
* Correct enrichment of FQDN indicators - it extracts all the related IPv4s and enriches them further ([#36](https://github.com/mlsecproject/combine/issues/36))
* Added contributing document to repository ([#127](https://github.com/mlsecproject/combine/issues/127))

#### 0.1.2 Bouncing Capybara
This is a bugfix release with several stability and performance improvements
Expand Down
138 changes: 138 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,138 @@
# Contributing to Combine

Want to hack on Combine? Awesome! Here are instructions to get you started. They are not perfect. Please let us know if anything feels wrong or incomplete.

Please note that this project is released with a [Contributor Code of Conduct](http://contributor-covenant.org/version/1/0/0/code_of_conduct.md) (or see code_of_conduct.md in this source code distribution). By participating in this project, you agree to abide by its terms.

## Reporting Security Issues

The Combine maintainers take security very seriously. If you discover a security issue, please bring it to our attention right away!

Please send your report privately to [security@mlsecproject.org](mailto:security@mlsecproject.org), please **DO NOT** file a public issue.

Security reports are greatly appreciated and we will publicly thank you for it. We currently do not offer a paid security bounty program, but are not ruling it out in the future.

## Design and Cleanup Proposals

When considering a design proposal, we are looking for:

* A description of the problem this design proposal solves
* A pull request, not an issue, that modifies the documentation describing the feature you are proposing, adding new documentation if necessary.
* Please prefix your issue with `Proposal:` in the title
* Please review [the existing proposals](https://github.com/mlsecproject/combine/pulls?q=is%3Aopen+is%3Apr+label%3AProposal) before reporting a new one. You can always pair with someone if you both have the same idea.

When considering a cleanup task, we are looking for:

* A description of the refactors made
* Please note any logic changes if necessary
* A pull request with the code
* Please prefix the title of your PR with `Cleanup:` so we can quickly address it.
* Your pull request must remain up to date with `dev`, so rebase as
necessary.

## Reporting Issues

A great way to contribute to the project is to send a detailed report when you encounter an issue. We always appreciate a well-written, thorough bug report and will thank you for it!

When reporting [issues](https://github.com/mlsecproject/combine/issues) on GitHub, please include your host OS (Ubuntu 12.04, Fedora 19, etc) and version of Python (from `python -V`).

Please also include the steps required to reproduce the problem if possible and applicable. This information will help us review and fix your issue faster.

### Template

```
Description of problem:
`Combine version`:
`Combine info`:
`python -V`:
How reproducible:
Steps to Reproduce:
1.
2.
3.
Actual Results:
Expected Results:
Additional info:
```

## Contribution guidelines

### Pull requests are always welcome

We are always thrilled to receive pull requests. We do our best to process them as quickly as possible. You're not sure if that typo is worth a pull request? Do it! We will appreciate it.

If your pull request is not accepted on the first try, don't be discouraged! If there's a problem with the implementation, we will provide feedback on what to improve.

We try very hard to keep Combine lean and focused. We don't want it to do everything for everybody. This means that we might decide against incorporating a new feature. However, we might help you find a way to implement that feature *on top of* Combine. For example, this might take the form of an add-on tool outside of the main repository that integrates with Combine.

### Create issues...

Any significant improvement should be documented as [a GitHub issue](https://github.com/mlsecproject/combine/issues) before anybody starts working on it.

### ...but check for existing issues first!

Please take a moment to check that an issue doesn't already exist documenting your bug report or improvement proposal. If it does, it never hurts to add a quick ":+1:" or "I have this problem too". This will help prioritize the most common problems and requests.

### Branches

We follow a simplified version of the popular [git flow](http://nvie.com/posts/a-successful-git-branching-model/).

* `master` MUST always be production-deployable. `dev` may not be ready for production but should pass all existing tests. (At the time of this writing, a test suite is under development.)
* The only branches that will be merged directly into master are `dev` (for a release) or hotfixes for significant bugs that need immediate attention. Hotfixes will merge into `master` and `dev`
* All other development forks off from the `dev` branch and merges back into it.

### Conventions

Fork the repository and make changes on your fork in a feature branch:

* Start from the `dev` branch.
* If it's a bug fix branch, name it iXXXX-something where XXXX is the number of the issue.
* If it's a feature branch, create an enhancement issue to announce your intentions and name it iXXXX-something where XXXX is the number of the issue.

Update the documentation when creating or modifying features. Review your documentation changes for clarity, concision, and correctness.

Write clean code. Universally formatted code promotes ease of writing, reading, and maintenance. Always run `pep8 file.py` on each changed file before committing your changes. Most editors have plug-ins that do this automatically. And yes, four spaces instead of tabs. We'll generally forgive long lines - but please be reasonable!

Pull requests descriptions should be as clear as possible and include a reference to all the issues that they address.

Commit messages should start with a short summary (max. 50 chars) written in the imperative, followed by an optional, more detailed explanatory text which is separated from the summary by an empty line.

Others will review your code review and may add comments to your pull request. Discuss, then make the suggested modifications and push additional commits to your feature branch. Be sure to post a comment after pushing. The new commits will show up in the pull request automatically, but the reviewers will not be notified unless you comment. If you collaborate with others and they want to add commits, they should issue a PR to your fork and you can merge it into your branch.

Pull requests must be cleanly rebased on top of the `dev` branch without multiple branches mixed into the PR.

**Git tip**: If your PR no longer merges cleanly, use `rebase dev` in your feature branch to update your pull request rather than `merge dev`.

Messages for commits that fix or close an issue should include a reference like `Closes #XXXX` or `Fixes #XXXX`, which will automatically close the issue when merged.

### Merge approval

Combine maintainers use :+1: or :shipit: in comments on the code review to indicate acceptance. Once it's approved, the maintainers will handle merging.

### Accept the CLA

All contributors to the MLSec Project open-source repositories need to sign an CLA (Contributor License Agreement) before their first contribution is merged into the main codebase. The maintainers will reach out to you if you require to sign a CLA when you first submit a Pull Request for review.

Everyone needs to sign a CLA for their code to be considered. Sadly, we will be forced to reject PRs from people that do not wish to sign one.

## References:
We based these on the excellent [Docker contribution guidelines](https://github.com/docker/docker/blob/master/CONTRIBUTING.md). And the Code of Conduct of course comes from [Contributor Covenant](http://contributor-covenant.org).
13 changes: 13 additions & 0 deletions code_of_conduct.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Contributor Code of Conduct

As contributors and maintainers of this project, we pledge to respect all people who contribute through reporting issues, posting feature requests, updating documentation, submitting pull requests or patches, and other activities.

We are committed to making participation in this project a harassment-free experience for everyone, regardless of level of experience, gender, gender identity and expression, sexual orientation, disability, personal appearance, body size, race, ethnicity, age, or religion.

Examples of unacceptable behavior by participants include the use of sexual language or imagery, derogatory comments or personal attacks, trolling, public or private harassment, insults, or other unprofessional conduct.

Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct. Project maintainers who do not follow the Code of Conduct may be removed from the project team.

Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by opening an issue or contacting one or more of the project maintainers.

This Code of Conduct is adapted from the [Contributor Covenant](http:contributor-covenant.org), version 1.0.0, available at [http://contributor-covenant.org/version/1/0/0/](http://contributor-covenant.org/version/1/0/0/)
Binary file modified data/GeoIP.dat
Binary file not shown.
Loading

0 comments on commit b8794f2

Please sign in to comment.