-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: comparison of torch tensors #1139
Conversation
@dfalbel what is your opinion on this, do you want this in the torch package at all? |
Yes, I think that's a useful feature! Do you mind checking why it fails on CI? We could also instead of registering onm package load, only register it when testing. Eg defining it in https://github.com/mlverse/torch/blob/main/tests/testthat/setup.R |
It should be fixed now. I would prefer to add it during package so other people (including myself) can use it in their tests as well. |
I am a bit confused by the failing windows test and the centos failure does not seem to be caused by this PR. |
Yes, it's failing on older R versions I think:
We could simply skip this tests if on R <= 4.0 if you want. The centOS error is indeed not related to this PR, don't worry about it. |
Thx for fixing the typo! I think we are good to merge here? |
Thank you @sebffischer ! |
I did not create a PR in waldo, because I think this method should be under full control of the torch package. I "hacked" it in, so waldo does not become a hard dependency here.