Bel_val scripts #29
Open
Bel_val scripts #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…probably be refined in the future to only print what we need!
…needs to be updated and verified. Just used current nvhpc/gpu output to create the scripts. The python script and notebooks bel_val.py and bel_val.ipynb currently do the same thing - extract u,v,w,vorticity, and divergence from two samurai_XYZ_analysis.out files and compare their RMSE, and print out the results.
sjsprecious
requested review from
mmbell,
sjsprecious,
johnmauff and
supreethms1809
sjsprecious
assigned cenamiller and unassigned mmbell, sjsprecious, johnmauff and supreethms1809
sjsprecious
reviewed
May 29, 2024
This wasn't a real reference file - just an example to test the notebook. Deleting to avoid future confusion.
Again, just a sample file to test the notebook. This file should be generated by the validation run, so we don't need to keep the example in the repo.
sjsprecious
reviewed
Jun 4, 2024
There was a problem hiding this comment.
Thanks @cenamiller for working on this PR. It seems that the newly added TDRP file is not tested in the CI workflow and the python/notebook scripts are not used, either. Would you mind explaining how you are going to use them later?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scripts and test output files for setting up ci/cd validation. Need verified reference output, then can be integrated into ci workflow.