-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a decorator for teeplot
called teewrap
#9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few simplifying suggestions.
Started a build on master to see if this is a general CI problem or specific to this branch 👍 https://github.com/mmore500/teeplot/actions/runs/13340934882 |
teeplot/teeplot.py
Outdated
@@ -377,3 +378,38 @@ def teed(*args: list, **kwargs: dict): | |||
yield handle | |||
finally: | |||
saveit() | |||
|
|||
|
|||
def validate_teewrap_kwargs(teeplot_kwargs: dict[str, object]): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’d prefix with an underscore or maybe move inline now that it’s much simpler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve! Just a few minor comments to take care of before merging.
Ah, also looks like there’s |
Co-authored-by: Matthew Andres Moreno <mmore500.login+gpg@gmail.com>
Co-authored-by: Matthew Andres Moreno <mmore500.login+gpg@gmail.com>
No description provided.