Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a decorator for teeplot called teewrap #9

Merged
merged 15 commits into from
Feb 15, 2025
Merged

Conversation

vivaansinghvi07
Copy link
Collaborator

No description provided.

Copy link
Owner

@mmore500 mmore500 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few simplifying suggestions.

@mmore500
Copy link
Owner

Started a build on master to see if this is a general CI problem or specific to this branch 👍 https://github.com/mmore500/teeplot/actions/runs/13340934882

@@ -377,3 +378,38 @@ def teed(*args: list, **kwargs: dict):
yield handle
finally:
saveit()


def validate_teewrap_kwargs(teeplot_kwargs: dict[str, object]):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d prefix with an underscore or maybe move inline now that it’s much simpler

Copy link
Owner

@mmore500 mmore500 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve! Just a few minor comments to take care of before merging.

@mmore500
Copy link
Owner

Ah, also looks like there’s TypeError: 'type' object is not subscriptable in CI

vivaansinghvi07 and others added 3 commits February 15, 2025 17:27
Co-authored-by: Matthew Andres Moreno <mmore500.login+gpg@gmail.com>
Co-authored-by: Matthew Andres Moreno <mmore500.login+gpg@gmail.com>
@vivaansinghvi07 vivaansinghvi07 merged commit 4a2963b into master Feb 15, 2025
25 of 37 checks passed
@vivaansinghvi07 vivaansinghvi07 deleted the teewrap branch February 15, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants