Skip to content

Minor Bugfixed for shapiq.waterfall_plot #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025
Merged

Conversation

Advueu963
Copy link
Collaborator

TL;DR

This pull request addresses a bug in the waterfall_plot function, improves functionality, and enhances testing.
The changes include fixing visual issues in the plot, renaming the file for consistency, and adding safeguards to ensure proper rendering of y-ticks.

Bug Fixes and Enhancements to waterfall_plot:

  • Fixed a bug in the waterfall_plot function that caused y-ticks to be cut off. Slightly adjusted y_height and added logic to dynamically resize the figure width based on the maximum y-tick label width. [1] [2]
  • Replaced a formatting bug in y-tick labels with an f-string to correctly display the number of grouped features.

File Renaming for Consistency:

  • Renamed the file shapiq/plot/watefall.py to shapiq/plot/waterfall.py to match the function name and updated the import in shapiq/plot/__init__.py. [1] [2]

Testing Enhancements:

  • Updated test_waterfall_cooking_game to include visual inspection tests for scenarios with different max_display values, ensuring no cutoffs in the plot. [1] [2]

@Advueu963 Advueu963 self-assigned this May 5, 2025
@mmschlk mmschlk merged commit b87fcb4 into main May 6, 2025
8 checks passed
@mmschlk mmschlk deleted the fix_waterfall_plot branch May 6, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants