Minor Bugfixed for shapiq.waterfall_plot #377
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This pull request addresses a bug in the
waterfall_plot
function, improves functionality, and enhances testing.The changes include fixing visual issues in the plot, renaming the file for consistency, and adding safeguards to ensure proper rendering of y-ticks.
Bug Fixes and Enhancements to
waterfall_plot
:waterfall_plot
function that caused y-ticks to be cut off. Slightly adjusted y_height and added logic to dynamically resize the figure width based on the maximum y-tick label width. [1] [2]File Renaming for Consistency:
shapiq/plot/watefall.py
toshapiq/plot/waterfall.py
to match the function name and updated the import inshapiq/plot/__init__.py
. [1] [2]Testing Enhancements:
test_waterfall_cooking_game
to include visual inspection tests for scenarios with differentmax_display
values, ensuring no cutoffs in the plot. [1] [2]