Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly get PR number for merge group #1077

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Properly get PR number for merge group #1077

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bcd502
Properly get PR number for merge group
qinsoon Jan 28, 2024
2153c50
Fix: echo to $GITHUB_OUTPUT
qinsoon Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/workflows/minimal-tests-bindings.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,26 @@ jobs:
# This step allows 2mins before we check comments for binding repos/refs.
grace-period:
runs-on: ubuntu-latest
outputs:
pr-number: ${{ steps.set-output.outputs.pr-number }}
steps:
# This workflow runs for both merge_group and pull_request
# We need a way to get the pull request number that works for both cases.
# The action can do that.
- id: get-pr-number
uses: mgaitan/gha-get-pr-number@main
# This job also outputs the PR number
- id: set-output
run: echo "pr-number=${{ steps.get-pr-number.outputs.number }}" >> $GITHUB_OUTPUT
# Sleep for 2 mins
- run: sleep 120

# Figure out binding PRs.
binding-refs:
needs: grace-period
uses: ./.github/workflows/pr-binding-refs.yml
with:
pull_request: ${{ github.event.pull_request.number }}
pull_request: ${{ needs.grace-period.outputs.pr-number }}

minimal-tests-openjdk:
needs: binding-refs
Expand Down
Loading