Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ImmixSpace's
is_live
andget_forwarded_object
for mmtk/mmtk-openjdk#141 .The context of this PR:
OpenJDK has several object cache (or storage) that should be processed during GC. For example,
CodeCache
may contain embedded pointers. Our old approach is to treat all the objects in these storages as root pointers -- and caused memory leak. mmtk/mmtk-openjdk#141 tries to update these storages before the end of each GC, including removing dead objects and updating forwarded objects.To support this. all mmtk spaces should implement
is_live
andget_forwarded_object
correctly.@tianleq Looks like there's some difficulty implementing
get_forwarded_object
for MarkCompactSpace? Is it because the MarkCompactSpace does not useobject_forwarding
?TODO: MarkCompactSpace needs to be fixed as well...