spawn_gc_thread API change

mmtk/Cargo.toml

@@ -28,7 +28,7 @@ log = {version = "0.4", features = ["max_level_trace", "release_max_level_off"]
 # - change branch/rev
 # - change repo name
 # But other changes including adding/removing whitespaces in commented lines may break the CI.
-mmtk = { git = "https://github.com/wks/mmtk-core.git", rev = "7cb0b2c12be341c084e03f2cd943fad8ac088f83" }
+mmtk = { git = "https://github.com/wks/mmtk-core.git", rev = "fb752a41c67fb3a3f4ea7223c11acf099eb20131" }
 # Uncomment the following to build locally - if you change the path locally, do not commit the change in a PR
 # mmtk = { path = "../repos/mmtk-core" }
 

mmtk/src/collection.rs

@@ -2,6 +2,7 @@ use entrypoint::*;
 use mmtk::util::alloc::AllocationError;
 use mmtk::util::opaque_pointer::*;
 use mmtk::util::Address;
+use mmtk::vm::gc_thread::UnimplementedGCThreadJoinHandle;
 use mmtk::vm::ActivePlan;
 use mmtk::vm::{Collection, GCThreadContext};
 use mmtk::Mutator;
@@ -55,13 +56,18 @@ impl Collection<JikesRVM> for VMCollection {
         }
     }
 
-    fn spawn_gc_thread(tls: VMThread, ctx: GCThreadContext<JikesRVM>) {
+    fn spawn_gc_thread(
+        tls: VMThread,
+        ctx: GCThreadContext<JikesRVM>,
+    ) -> UnimplementedGCThreadJoinHandle {
         let ctx_ptr = match ctx {
             GCThreadContext::Worker(c) => Box::into_raw(c),
         };
         unsafe {
             jtoc_call!(SPAWN_COLLECTOR_THREAD_METHOD_OFFSET, tls, ctx_ptr);
         }
+
+        UnimplementedGCThreadJoinHandle
     }
 
     fn out_of_memory(tls: VMThread, _err_kind: AllocationError) {

mmtk/src/lib.rs

@@ -7,6 +7,7 @@ extern crate log;
 
 use mmtk::plan::PlanConstraints;
 use mmtk::util::address::Address;
+use mmtk::vm::gc_thread::UnimplementedGCThreadJoinHandle;
 use mmtk::vm::VMBinding;
 use mmtk::MMTKBuilder;
 use mmtk::MMTK;
@@ -59,6 +60,8 @@ impl VMBinding for JikesRVM {
     type VMEdge = JikesRVMEdge;
     type VMMemorySlice = mmtk::vm::edge_shape::UnimplementedMemorySlice<JikesRVMEdge>;
 
+    type VMGCThreadJoinHandle = UnimplementedGCThreadJoinHandle;
+
     #[cfg(target_arch = "x86")]
     // On Intel we align code to 16 bytes as recommended in the optimization manual.
     const MAX_ALIGNMENT: usize = 1 << 4;