bootstrap.peg: Fix incorrect quote escapes and raw string length #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breml
force-pushed
the
fix/bootstrap-quotes
branch
from
5de9012
to
0af99db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR that addresses the issue I had with compiling the first fix in #115. This is a separate bug and does not close #115, but only enables a fix for #115.
Firstly, it fixes incorrect quote escapes for interpreted string literals and rune literals, which were swapped (in interpreted strings
\'could be escaped and rune literals\"could be escaped; the opposite would be correct).Secondly, it fixes raw strings being limited to a one rune length, due to a missing
*.If I understand correctly, the tests in the
testdirectory only testgrammar/pigeon.pegbut notgrammar/bootrap.peg. Therefore, I'm not sure where and if to test this.