Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub actions #162

Merged
merged 2 commits into from
Nov 16, 2024
Merged

Update GitHub actions #162

merged 2 commits into from
Nov 16, 2024

Conversation

meyermarcel
Copy link
Contributor

  • actions/checkout v4 is available
  • actions/setup-go v5 is availabe, v4+ has an integrated cache
    • Caching in ci.yml was removed
    • Caching in go-cross.yml was not touched because more stuff is cached
  • actions/cache v4 is available
  • golangci/golangci-lint-action is available and has CI optimized caching integrated
  • Go 1.23 (current stable) can check clean dependencies with go mod tidy -diff
  • actions/go-dependency-submission v2 is available

* actions/checkout v4 is available
* actions/setup-go v5 is availabe, v4+ has an integrated cache
  * Caching in ci.yml was removed
  * Caching in go-cross.yml was not touched because more stuff is cached
* actions/cache v4 is available
* golangci/golangci-lint-action is available and has CI optimized caching integrated
* Go 1.23 (current stable) can check clean dependencies with `go mod tidy -diff`
* actions/go-dependency-submission v2 is available
@meyermarcel
Copy link
Contributor Author

meyermarcel commented Nov 14, 2024

Hey @breml ,
I love this great library and I saw that some GitHub actions could be updated. Sorry for changing so much. If you want the PR to be a smaller scope I can shrink the scope of the PR, please let me know :)

Suggestions:

  • Instead of v1.62.0 v1.62 would use also fixes to golanci-lint.
  • Go version in ci.yml (stable -> 1.23) diverges from go.mod (1.22.0).
    • Maybe using 1.22 instead of 1.22.0 would not pin to a specific patch version
    • We could use go-version-file: "go.mod" (see actions/setup-go docs) to use the Go version defined in go.mod.

@breml
Copy link
Collaborator

breml commented Nov 16, 2024

Hey @breml , I love this great library and I saw that some GitHub actions could be updated. Sorry for changing so much. If you want the PR to be a smaller scope I can shrink the scope of the PR, please let me know :)

PR size is fine for me.

Suggestions:

  • Instead of v1.62.0 v1.62 would use also fixes to golanci-lint.

I am fine with v1.62 instead of v1.62.0.

  • Go version in ci.yml (stable -> 1.23) diverges from go.mod (1.22.0).

This is not a problem. This can stay as is.

  • Maybe using 1.22 instead of 1.22.0 would not pin to a specific patch version

Agree, you may change this to 1.22.

  • We could use go-version-file: "go.mod" (see actions/setup-go docs) to use the Go version defined in go.mod.

I prefer to keep it explicit to stable and oldstable.

@meyermarcel
Copy link
Contributor Author

meyermarcel commented Nov 16, 2024

  • Maybe using 1.22 instead of 1.22.0 would not pin to a specific patch version

Agree, you may change this to 1.22.

Maybe I do not know how this works. If I change to 1.22 the toolchain definition becomes my local toolchain -> toolchain go1.23.3. So maybe it is better to leave it as it is. I changed only the golangci-lint version.

Copy link
Collaborator

@breml breml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breml breml merged commit b6c2404 into mna:master Nov 16, 2024
10 checks passed
@meyermarcel meyermarcel deleted the update-github-actions branch November 16, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants