Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GSOC] Add decomposition plotting #208

Merged
merged 52 commits into from
Jul 3, 2024
Merged

[GSOC] Add decomposition plotting #208

merged 52 commits into from
Jul 3, 2024

Conversation

tsbinns
Copy link
Collaborator

@tsbinns tsbinns commented Jun 20, 2024

As described in #182.

This adds support for visualising spatial filters and patterns as topomaps with the plot_filters and plot_patterns method of the CoherencyDecomposition class. Very similar to the methods of the same name in the CSP class of MNE's decoding module.

Unit tests added as well as a short example on how these methods can be used and the figures interpreted.

tsbinns added 30 commits May 28, 2024 14:50
@tsbinns
Add filter storage
2fa5aca
@tsbinns
Merge branch 'mne-tools:main' into decoding
6e206ce
@tsbinns
Refactor results reshaping
68a0890
@tsbinns
Fix filter indexing for storage
0368367
@tsbinns
Update fill_doc dictionary
bb75cb1
@tsbinns
Add n_components to ingored numpydoc words
115757c
@tsbinns
Add decoding module
e7c9da9
@tsbinns
Update API with decoding module
5e51923
@tsbinns
Rename file and add suport for cwt_morlet mode
9fe0f28
@tsbinns
Merge branch 'main' into decoding
6302a4d
@tsbinns
Make property docstrings private
fa6a001
@tsbinns
Bug fix error check
15e99e4
@tsbinns
Bug fix fit_transform no return
58eca90
@tsbinns
Bug fix _check_X 2d array
9b43dfb
@tsbinns
Add preliminary decomp example
bb0b520
@tsbinns
Merge branch 'main' into decoding
cdc7ce4
@tsbinns
Merge branch 'main' into decoding
8cd98e1
@tsbinns
Switch to cleaner epoch indexing
a3bf253
@tsbinns
Fix spelling error
ea48ce3
@tsbinns
Update error checking
9bcff58
@tsbinns
Merge branch 'decoding' of https://github.com/tsbinns/mne-connectivity …
17cfeab 
…into decoding
@tsbinns
Bug fix indices setter wrong format
6c8ae97
@tsbinns
Add unit tests
55b14ab
@tsbinns
Update example from review
3861da5
@tsbinns
Update cwt_morlet params
025e6c1
@tsbinns
Fix platform-specific failing unit test
cbfcc13
@tsbinns
Refactor decomposition classes
8339d40
@tsbinns
Add test reminder
bdfb626
@tsbinns
Add decomposition plotting
a0e9560
@tsbinns
Update tests and fix getter/setters
840f4f6
larsoner
larsoner reviewed Jun 25, 2024
View reviewed changes
Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments, the rendered example looks nice!

@wmvanvliet want to take a look?

mne_connectivity/decoding/decomposition.py Outdated Show resolved Hide resolved
mne_connectivity/decoding/decomposition.py Outdated Show resolved Hide resolved
wmvanvliet
wmvanvliet requested changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@wmvanvliet wmvanvliet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super small nitpicks. This looks great! The tutorial is informative and will be a nice addition to the docs.

examples/decoding/cohy_decomposition_plotting.py Outdated Show resolved Hide resolved
@tsbinns
Copy link
Collaborator Author

tsbinns commented Jun 26, 2024

Thanks both for the feedback! That should be everything addressed.

@adam2392
Copy link
Member

Vey slick figures :)

larsoner
larsoner approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tsbinns !

@larsoner larsoner merged commit f27793c into mne-tools:main Jul 3, 2024
12 checks passed
@tsbinns tsbinns deleted the decoding_plotting branch July 4, 2024 10:01
@tsbinns tsbinns mentioned this pull request Jul 29, 2024
Closed
@tsbinns tsbinns mentioned this pull request Aug 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam2392 adam2392 adam2392 left review comments

@wmvanvliet wmvanvliet wmvanvliet requested changes

@larsoner larsoner larsoner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tsbinns @adam2392 @wmvanvliet @larsoner