Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase-slope index using spectral_connectivity_time instead of spectral_connectivity_epochs #210
base: main
Are you sure you want to change the base?
Phase-slope index using spectral_connectivity_time instead of spectral_connectivity_epochs #210
Changes from 8 commits
2631a83
388ab8c
c38374a
b44da50
75a72b5
6cef3cb
dffda01
ef0a484
be0c3cd
ce68935
401a6a8
573211d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would think the default should be
"cwt_morlet"
, like inspectral_connectivity_time()
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just make sure we're referencing the right function, and while doing that, let's make it a link in the docs (though I see it isn't already in
phase_slope_index
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also include
Epochs
(again, I realise you took this from the existing function which doesn't have this, so should change there too).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No Fourier mode for
spec_conn_time
, but can also make this a little more consistent with the description given there.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if it's good to reiterate that
spectral_connectivity_time()
is a relevant function. Though I realise you based this on the existing function docstring which doesn't link tospec_conn_epochs()
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think this is a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder if we should expose more of these options to the user, e.g. why just
padding
and not the smoothing stuff?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a quick glance the test looks good to me, let's see if it passes once the
verbose
param is added to the new function.