Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Use explicitly public APIs #521

Merged
merged 12 commits into from
Aug 22, 2023
Merged

MAINT: Use explicitly public APIs #521

merged 12 commits into from
Aug 22, 2023

Conversation

larsoner
Copy link
Member

In mne-tools/mne-python#11903 we're trying to make some mne/io stuff private. This changes mne-nirs to use the explicitly public API

Also includes a number of fixes for latest NumPy/SciPy/Pandas

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #521 (d40efea) into main (b518247) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #521      +/-   ##
==========================================
- Coverage   95.28%   95.22%   -0.07%     
==========================================
  Files          69       69              
  Lines        2865     2868       +3     
  Branches      412      412              
==========================================
+ Hits         2730     2731       +1     
- Misses         65       66       +1     
- Partials       70       71       +1     
Files Changed Coverage Δ
mne_nirs/conftest.py 96.49% <ø> (ø)
mne_nirs/preprocessing/tests/test_mayer.py 100.00% <100.00%> (ø)
mne_nirs/statistics/_glm_level_first.py 88.58% <100.00%> (+0.78%) ⬆️
mne_nirs/statistics/_statsmodels.py 91.02% <100.00%> (+0.11%) ⬆️
mne_nirs/statistics/tests/test_glm_type.py 98.99% <100.00%> (-1.01%) ⬇️
mne_nirs/tests/test_examples.py 80.64% <100.00%> (-6.86%) ⬇️
mne_nirs/utils/_io.py 96.25% <100.00%> (ø)
mne_nirs/visualisation/_plot_3d_montage.py 98.01% <100.00%> (-0.02%) ⬇️
mne_nirs/visualisation/_plot_GLM_topo.py 85.23% <100.00%> (ø)

Copy link
Member

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicks (I like examples to show what we consider best practices)

examples/general/plot_10_hrf_simulation.py Outdated Show resolved Hide resolved
examples/general/plot_10_hrf_simulation.py Outdated Show resolved Hide resolved
examples/general/plot_10_hrf_simulation.py Outdated Show resolved Hide resolved
examples/general/plot_11_hrf_measured.py Outdated Show resolved Hide resolved
Co-authored-by: Daniel McCloy <dan@mccloy.info>
@larsoner larsoner enabled auto-merge (squash) August 22, 2023 16:56
@larsoner larsoner merged commit c7cf346 into mne-tools:main Aug 22, 2023
17 of 18 checks passed
@larsoner larsoner deleted the public branch August 22, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants