Skip to content

Feat added internet permission #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DreXuri wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Feat added internet permission #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f61628
ui_changes
DreXuri Dec 6, 2023
54fd467
added internet permission
DreXuri Dec 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions android/app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
<user-permisiion android: name= "android.permission.INTERNET"/>
<application
android:label="receipe_app"
android:name="${applicationName}"
Expand Down Expand Up @@ -31,3 +32,4 @@
android:value="2" />
</application>
</manifest>
S
1 change: 0 additions & 1 deletion lib/ui/views/new_dish/new_dish_viewmodel.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ class NewDishViewModel extends FormViewModel {
);

final response = await _dishService.createDish(info);

if (response != null) {
Copy link
Owner

@moak13 moak13 Jan 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, actually for this, you need to take care of the null, it's something that can happen and we need to let the user know that an unknown error has occurred. Using the negative first approach to building the success area in a try-and-catch block helps solve a lot in the mobile space.

Copy link
Contributor

@ClementPeter ClementPeter Jan 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡

DialogResponse<dynamic>? dialogResponse =
await _dialogService.showDialog(
Expand Down
1 change: 1 addition & 0 deletions lib/ui/views/signup/signup_viewmodel.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ class SignupViewModel extends FormViewModel {
await _dialogService.showDialog(
description: "Account created successfully.",
Copy link
Owner

@moak13 moak13 Jan 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we are using l10n for our texts?

);

}
} on RecipeException catch (e) {
_dialogService.showDialog(
Expand Down