Test coverage + CodeClimate #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nebolsin
commented
Jul 7, 2018
nebolsin
commented
- Send test coverage reports to Codeclimate
- Add maintainability badges
nebolsin
force-pushed
the
chore/codeclimate
branch
from
1372ff4 to
e26ed04
Compare
lysyi3m
reviewed
Jul 10, 2018
| export default class Account { | ||
| /** | ||
| * @param {object} account | ||
| * @param {StellarSdk.Keypair} keypair |
Contributor
There was a problem hiding this comment.
Since mobius-client-js has no Keypair class, it would be better to mention Stellar SDK's methods explicitly
lysyi3m
reviewed
Jul 10, 2018
| } | ||
|
|
||
| /** | ||
| * @param {StellarSdk.Keypair} toKeypair |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.