Skip to content

Commit

Permalink
Fix issue #269 for old ESP32 Core SDK (v1.0.6 and older) compilation …
Browse files Browse the repository at this point in the history
…error due to ambiguous in WiFiClient's setSocketOption.
  • Loading branch information
mobizt committed Jul 4, 2023
1 parent af0d684 commit 4ddd51a
Show file tree
Hide file tree
Showing 16 changed files with 22 additions and 20 deletions.
2 changes: 1 addition & 1 deletion library.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ESP Mail Client",
"version": "3.1.12",
"version": "3.1.13",
"keywords": "communication, email, imap, smtp, esp32, esp8266, samd, arduino",
"description": "Arduino E-Mail Client Library to send, read and get incoming email notification for ESP32, ESP8266 and SAMD21 devices. The library also supported other Arduino Devices using Clients interfaces e.g. WiFiClient, EthernetClient, and GSMClient.",
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion library.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name=ESP Mail Client

version=3.1.12
version=3.1.13

author=Mobizt

Expand Down
2 changes: 1 addition & 1 deletion src/ESP_Mail_Client.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#define ESP_MAIL_CLIENT_CPP

#include "ESP_Mail_Client_Version.h"
#if !VALID_VERSION_CHECK(30112)
#if !VALID_VERSION_CHECK(30113)
#error "Mixed versions compilation."
#endif

Expand Down
2 changes: 1 addition & 1 deletion src/ESP_Mail_Client.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#define ESP_MAIL_CLIENT_H

#include "ESP_Mail_Client_Version.h"
#if !VALID_VERSION_CHECK(30112)
#if !VALID_VERSION_CHECK(30113)
#error "Mixed versions compilation."
#endif

Expand Down
4 changes: 2 additions & 2 deletions src/ESP_Mail_Client_Version.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@

#ifndef ESP_MAIL_VERSION

#define ESP_MAIL_VERSION "3.1.12"
#define ESP_MAIL_VERSION_NUM 30112
#define ESP_MAIL_VERSION "3.1.13"
#define ESP_MAIL_VERSION_NUM 30113

/* The inconsistent file version checking to prevent mixed versions compilation. */
#define VALID_VERSION_CHECK(ver) (ver == ESP_MAIL_VERSION_NUM)
Expand Down
2 changes: 1 addition & 1 deletion src/ESP_Mail_Const.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#define ESP_MAIL_CONST_H

#include "ESP_Mail_Client_Version.h"
#if !VALID_VERSION_CHECK(30112)
#if !VALID_VERSION_CHECK(30113)
#error "Mixed versions compilation."
#endif

Expand Down
2 changes: 1 addition & 1 deletion src/ESP_Mail_Error.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
#define ESP_MAIL_ERROR_H

#include "ESP_Mail_Client_Version.h"
#if !VALID_VERSION_CHECK(30112)
#if !VALID_VERSION_CHECK(30113)
#error "Mixed versions compilation."
#endif

Expand Down
2 changes: 1 addition & 1 deletion src/ESP_Mail_FS.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#define ESP_MAIL_CONFIG_H

#include "ESP_Mail_Client_Version.h"
#if !VALID_VERSION_CHECK(30112)
#if !VALID_VERSION_CHECK(30113)
#error "Mixed versions compilation."
#endif

Expand Down
2 changes: 1 addition & 1 deletion src/ESP_Mail_IMAP.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#define ESP_MAIL_IMAP_H

#include "ESP_Mail_Client_Version.h"
#if !VALID_VERSION_CHECK(30112)
#if !VALID_VERSION_CHECK(30113)
#error "Mixed versions compilation."
#endif

Expand Down
2 changes: 1 addition & 1 deletion src/ESP_Mail_Print.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#define ESP_MAIL_PRINT_H_

#include "ESP_Mail_Client_Version.h"
#if !VALID_VERSION_CHECK(30112)
#if !VALID_VERSION_CHECK(30113)
#error "Mixed versions compilation."
#endif

Expand Down
2 changes: 1 addition & 1 deletion src/ESP_Mail_SMTP.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#define ESP_MAIL_SMTP_H

#include "ESP_Mail_Client_Version.h"
#if !VALID_VERSION_CHECK(30112)
#if !VALID_VERSION_CHECK(30113)
#error "Mixed versions compilation."
#endif

Expand Down
2 changes: 1 addition & 1 deletion src/extras/MB_Time.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#define MB_Time_H

#include "ESP_Mail_Client_Version.h"
#if !VALID_VERSION_CHECK(30112)
#if !VALID_VERSION_CHECK(30113)
#error "Mixed versions compilation."
#endif

Expand Down
2 changes: 1 addition & 1 deletion src/extras/RFC2047.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#define RFC2047_CPP

#include "ESP_Mail_Client_Version.h"
#if !VALID_VERSION_CHECK(30112)
#if !VALID_VERSION_CHECK(30113)
#error "Mixed versions compilation."
#endif

Expand Down
2 changes: 1 addition & 1 deletion src/extras/RFC2047.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#define RFC2047_H

#include "ESP_Mail_Client_Version.h"
#if !VALID_VERSION_CHECK(30112)
#if !VALID_VERSION_CHECK(30113)
#error "Mixed versions compilation."
#endif

Expand Down
4 changes: 2 additions & 2 deletions src/wcs/esp32/ESP32_WCS.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*
* ESP32 WiFi Client Secure v2.0.4
* ESP32 WiFi Client Secure v2.0.5
*
* Created June 17, 2023
* Created July 4, 2023
*
* The MIT License (MIT)
* Copyright (c) 2023 K. Suwatchai (Mobizt)
Expand Down
8 changes: 5 additions & 3 deletions src/wcs/esp32/ESP32_WCS.h
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*
* ESP32 WiFi Client Secure v2.0.4
* ESP32 WiFi Client Secure v2.0.5
*
* Created June 17, 2023
* Created July 4, 2023
*
* The MIT License (MIT)
* Copyright (c) 2023 K. Suwatchai (Mobizt)
Expand Down Expand Up @@ -420,7 +420,9 @@ class ESP32_WCS : public ESP_Mail_WCS_CLASS, public TCP_Client_Base
#if !defined(ENABLE_CUSTOM_CLIENT)
int setOption(int option, int *value)
{
return reinterpret_cast<WiFiClient *>(_ssl->client)->setSocketOption(IPPROTO_TCP, option, (const void *)value, sizeof(int));
// Actually we wish to use setSocketOption directly but it is ambiguous in old ESP32 core v1.0.x.;
// Use setOption instead for old core support.
return reinterpret_cast<WiFiClient *>(_ssl->client)->setOption(option, value);
}
#endif

Expand Down

0 comments on commit 4ddd51a

Please sign in to comment.