Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: moble/Quaternionic.jl
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.0.0
Choose a base ref
...
head repository: moble/Quaternionic.jl
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
  • 9 commits
  • 16 files changed
  • 4 contributors

Commits on Oct 22, 2024

  1. Update CI badges

    moble authored Oct 22, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    2cf7478 View commit details

Commits on Nov 18, 2024

  1. Bump codecov/codecov-action from 4 to 5 (#69)

    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Nov 18, 2024
    Copy the full SHA
    1933afe View commit details

Commits on Jan 3, 2025

  1. Copy the full SHA
    721b5f1 View commit details
  2. Correct typo

    moble committed Jan 3, 2025
    Copy the full SHA
    43e6d1f View commit details
  3. Correct typo

    moble committed Jan 3, 2025
    Copy the full SHA
    75e8a1d View commit details
  4. Correct typo

    moble committed Jan 3, 2025
    Copy the full SHA
    e06e1b2 View commit details
  5. 4
    Copy the full SHA
    7d00c98 View commit details

Commits on Feb 26, 2025

  1. Replace Base.eltype with Quaternionic.basetype (#71)

    This will cause breaking changes.  First, `Base.eltype` is no longer defined on any quaternionic type.  It was defined to return the `T` in an `AbstractQuaternion{T}`.  This was the source of some broadcasting issues, because broadcasting essentially recursively searches for the `eltype` of a vector, meaning that a vector of — say — `Quaternion{Float64}` would appear to broadcasting to have type `Float64`.  The new function `basetype` provides the same functionality.  This closes #15 and #70.
    
    While fixing this, a floating-point change in the tests pointed out that `conj` and `-` acting on `Rotor`s would re-normalize, which is not really necessary and — in the case of `Float16` — can significantly change the components even when the original was already normalized.  These now skip the extra normalization step.
    
    Changing that, in turn, uncovered a subtle bug in the method of `align` that was intended to align vectors of `Rotor`s, but did not actually specify the input types, allowing it to mistakenly apply to vectors that were intended to be `QuatVec`s, though one accidentally changed to `Quaternion`.  This change will cause a MethodError to raise when using unintended types.
    moble authored Feb 26, 2025
    Copy the full SHA
    aab1936 View commit details
  2. 4
    Copy the full SHA
    8747b36 View commit details
Loading