Add QUATERNIONIC_DISABLE_CACHE environment variable. #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It may not always be desirable to cache the Numba-generated code, for example in a HPC environment where having lots of workers each compiling the code may be preferable to them all trying to load it from the cache. This adds a QUATERNIONIC_DISABLE_CACHE environment variable. If set to 1, the `cache` parameter of the `jit` and `guvectorize` decorators is set to False. Default behaviour remains the same as before, i.e., to use the cache.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
=======================================
Coverage 97.90% 97.90%
=======================================
Files 10 10
Lines 1096 1098 +2
Branches 230 230
=======================================
+ Hits 1073 1075 +2
Misses 21 21
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
Thanks very much! This is a very helpful and complete contribution. I appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may not always be desirable to cache the Numba-generated code, for example in a HPC environment where having lots of workers each compiling the code may be preferable to them all trying to load it from the cache.
This adds a QUATERNIONIC_DISABLE_CACHE environment variable. If set to 1, the
cacheparameter of thejitandguvectorizedecorators is set to False. Default behaviour remains the same as before, i.e., to use the cache.For the record, I have also made a pull request to Numba (numba/numba#9702) adding a environment variable to disable all caching. I figured that having the option just to disable it in quaternionic may be useful (and also, quaternionic would be quicker to have a release containing it allowing me to use it in my application sooner!).