Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test PR do not merge #3012

Open
wants to merge 1 commit into
base: bump_v19.03
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
# Needed to install go
OS: linux
ARCH: amd64
GOVERSION: 1.11
GOVERSION: 1.13
# Needed to install protoc
PROTOC_VERSION: 3.6.1

Expand Down
8 changes: 7 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# NOTE(dperny): for some reason, alpine was giving me trouble
FROM golang:1.11.0-stretch
ARG GO_VERSION=1.13.15
ARG DEBIAN_FRONTEND=noninteractive
ARG BASE_DEBIAN_DISTRO="buster"
ARG GOLANG_IMAGE="golang:${GO_VERSION}-${BASE_DEBIAN_DISTRO}"

FROM ${GOLANG_IMAGE}

RUN apt-get update && apt-get install -y make git unzip

Expand All @@ -16,6 +21,7 @@ WORKDIR /go/src/github.com/docker/swarmkit/
# install the dependencies from `make setup`
# we only copy `direct.mk` to avoid busting the cache too easily
COPY direct.mk .
COPY hack/protobuild hack/protobuild
RUN make --file=direct.mk setup

# now we can copy the rest
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -332,3 +332,5 @@ drzndxnjz3c8iujdewzaplgr6 redis 5 redis:3.0.7 RUNNING
```

As you can see, every Task running on `node-1` was rebalanced to either `node-2` or `node-3` by the reconciliation loop.


6 changes: 5 additions & 1 deletion direct.mk
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,11 @@ setup: ## install dependencies
# install golangci-lint version 1.17.1 to ./bin/golangci-lint
@curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s v1.17.1
@go get -u github.com/lk4d4/vndr
@go get -u github.com/stevvooe/protobuild
# horrid, awful hack to fix CI. we use a version of protobuild that predates
# some changes that result in it failing on some newer version because of
# dependencies. this is a binary checked into this branch, then copied into
# the go path where it would be expected.
@cp ./hack/protobuild ./bin/protobuild

.PHONY: generate
generate: protos
Expand Down
Binary file added hack/protobuild
Binary file not shown.