Skip to content

Replace library globals with configurable props #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace library globals with configurable props #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions lib/DragSortableView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@ const {width} = Dimensions.get('window')

const defaultZIndex = 8
const touchZIndex = 99
const maxScale = 1.1
const minOpacity = 0.8
const scaleDuration = 100
const slideDuration = 300

export default class DragSortableView extends Component{

Expand Down Expand Up @@ -68,8 +64,8 @@ export default class DragSortableView extends Component{
Animated.timing(
this.state.dataSource[touchIndex].scaleValue,
{
toValue: maxScale,
duration: scaleDuration,
toValue: this.props.maxScale,
duration: this.props.scaleDuration,
}
).start(()=>{
this.touchCurItem = {
Expand Down Expand Up @@ -184,7 +180,7 @@ export default class DragSortableView extends Component{
item.position,
{
toValue: {x: parseInt(nextItem.originLeft+0.5),y: parseInt(nextItem.originTop+0.5)},
duration: slideDuration,
duration: this.props.slideDuration,
easing: Easing.out(Easing.quad),
}
).start()
Expand All @@ -208,7 +204,7 @@ export default class DragSortableView extends Component{
this.state.dataSource[this.touchCurItem.index].scaleValue,
{
toValue: 1,
duration: scaleDuration,
duration: this.props.scaleDuration,
}
).start()
this.touchCurItem.ref.setNativeProps({
Expand Down Expand Up @@ -369,8 +365,8 @@ export default class DragSortableView extends Component{
left: item.position.x,
top: item.position.y,
opacity: item.scaleValue.interpolate({
inputRange:[1,maxScale],
outputRange:[1,minOpacity]
inputRange:[1,this.props.maxScale],
outputRange:[1,this.props.minOpacity]
}),
transform: [transformObj]
}]}>
Expand Down Expand Up @@ -433,6 +429,10 @@ DragSortableView.defaultProps = {
scaleStatus: 'scale',
fixedItems: [],
isDragFreely: false,
maxScale: 1.1,
minOpacity: 0.8,
scaleDuration: 100,
slideDuration: 300,
}

const styles = StyleSheet.create({
Expand Down
2 changes: 1 addition & 1 deletion lib/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-native-drag-sort",
"version": "1.3.5",
"version": "1.4.0",
"description": "Drag and drop sort control for react-native",
"main": "index.js",
"scripts": {
Expand Down