This repository was archived by the owner on May 2, 2023. It is now read-only.
Fix humidity text overlapping other modules#21
Open
parnic wants to merge 2 commits intomochman:masterfrom
Open
Fix humidity text overlapping other modules#21parnic wants to merge 2 commits intomochman:masterfrom
parnic wants to merge 2 commits intomochman:masterfrom
Conversation
This moves the main "circle" display into its own div so the humidity text can sit beneath it, and converts a lot of the absolute positioning into normal positioning to let the browser's layout engine encompass everything correctly into the parent "module-content" div. Tested in visual and list modes; left and right sides; and in "nest", "protect", and "both" display modes. Fixes mochman#18
parnic
force-pushed
the
fix-humidity-overlap
branch
from
32cc7ec to
7e5b94b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the main "circle" display into its own div so the humidity text can
sit beneath it, and converts a lot of the absolute positioning into normal
positioning to let the browser's layout engine encompass everything correctly
into the parent "module-content" div.
Tested in visual and list modes; left and right sides; and in "nest", "protect",
and "both" display modes.
Fixes #18