Fixing pkgconf URLs

[rominator1983]

No description provided.

[rominator1983]

@falkTX please check this once for yourself. I did a build with PopOs! that seemed to work despite my changes here.

Anyhow the old pkgconf URLs are not reachable anymore so I updated those. Someone must have deleted all the releases in favor of the tags. Github seems to provide a .tar.gz for tags out of the box.

I also do not know how things worked without the autoreconf call. Most of those things are beyond my C/C++/make skills. I hope you know, what to make of this.

[falkTX]

some of the changes here are really superfulous, glibc-source as dependency makes no sense.

only way I see around this is to put some automated testing for a bunch of distros at once.

[rominator1983]

i see. it seemed that this would have been necessary but I do get a feeling of why it really isn't.

Anyways the call to autoreconf also does not work since the directory is missing first.
Do you maybe know why my ./configure would be missing for host-pkgconf?

[rominator1983]

so a bunch of libraries (libc ...) are built before the plugins can be built on a system. Might it be that the separation of the libraries is not that perfect?

I had some errors that definitively went away after for example installing libpulse-dev

[rominator1983]

I'll reduce the PR to the fix of the URLs. I think that might really be needed.

[rominator1983]

that's done. Ok for you @falkTX ?

[rominator1983]

Ok. I have confirmed it with PopOs! too.
The configure-File needs to be created with an autoreconf call. But the call can't be made before the host-pkgconf-directory is present.

I do not really know why that is and if the old (non existent) .tar.bz2 of pkgconf had a configure file in it.
@falkTX Do you know where there could be a hook to call autoreconf for host-pkgconf?

[falkTX]

I do not really know why that is and if the old (non existent) .tar.bz2 of pkgconf had a configure file in it.
@falkTX Do you know where there could be a hook to call autoreconf for host-pkgconf?

we need to use a proper release tarball and not one generated from github, as that is a 1:1 copy of the git repo so that is why it misses those files.
actual release tarballs have some steps done by upstream to generate these files in an automatic way.

[falkTX]

from pkgconf readme they state we should use https://distfiles.ariadne.space/pkgconf as tarball download URL.
that includes the file we need, and sum matches:

$ sha256sum pkgconf-0.9.12.tar.bz2
7ec8b516e655e247f4ba976837cee808134785819ab8f538f652fe919cc6c09f  pkgconf-0.9.12.tar.bz2

[rominator1983]

Then I will use that and adapt my PR

[rominator1983]

done @falkTX

[rominator1983]

the last commit added a patch for locale.h in order to fix #175

I seriously do not know how that would work on another machine

[falkTX]

Thanks, I still want to add some CI jobs to test all these different distro versions...
Specially important for newer ones that have not yet been tested

[falkTX]

CI stuff is in place, and we can confirm the build issue indeed.

Please rebase/update this PR against latest master, thanks!

[rominator1983]

sorry for the delay. I did sync

[falkTX]

thanks, now we wait to see if all is good.

[rominator1983]

oh. so you do mainly build on debian and ubuntu too? good to know.
I will probably switch to Ubuntu studio since pipewire does not produce acceptable latencies in my setup as of some recent update and jack seems only to be supported reasonably well in Ubuntu Studio :-(

[falkTX]

oh. so you do mainly build on debian and ubuntu too? good to know.

personally yes, so this is easy to setup in CI. but we want to have at least archlinux in there too, so we test a rolling release with the freshest stuff.

[falkTX]

Your 2nd file is malformed and fails to apply.

2023-10-29T21:44:08.3398637Z Applying 002_bits_types_locale_t.patch using patch: 
2023-10-29T21:44:08.3417263Z can't find file to patch at input line 3
2023-10-29T21:44:08.3417943Z Perhaps you used the wrong -p or --strip option?
2023-10-29T21:44:08.3418508Z The text leading up to this was:
2023-10-29T21:44:08.3418981Z --------------------------
2023-10-29T21:44:08.3419612Z |--- a/glibc/locale/locale.h	2023-10-23 23:21:09.629352607 +0200
2023-10-29T21:44:08.3421661Z |+++ b/glibc/locale/locale.h	2023-10-23 23:20:54.853093115 +0200
2023-10-29T21:44:08.3422306Z --------------------------
2023-10-29T21:44:08.3422707Z No file to patch.  Skipping patch.
2023-10-29T21:44:08.3423169Z 1 out of 1 hunk ignored
2023-10-29T21:44:08.3423681Z Patch failed!  Please fix 002_bits_types_locale_t.patch!
2023-10-29T21:44:08.3425582Z make: *** [package/pkg-generic.mk:163: /github/home/mod-workdir/modduox/build/host-localedef-2.14.1-r17443-ptx1/.stamp_patched] Error 1

[rominator1983]

i see. must have been some change in the meantime. i will check on my machine

[rominator1983]

but its definitely a 23.10 thing considering the build output

[rominator1983]

where did you find this in the logs?

[rominator1983]

ah. got it. one failed the others were cancelled

[rominator1983]

I did a fix for this on my Ubuntu 23.10. Probably also working on Ubuntu Studio 23.10 where this is still running.

I do not know if this will work on any other machines since builds were green before this change and this was my fix to the malformed patch file: c2014c3

Looks like the folder is eglibc on 23.10 and glibc on other machines?

[falkTX]

the packages should be the same for all distros.

anyhow, I should have a deeper look at this. lets see what the next build says.

[rominator1983]

well that seemed to do the trick

[falkTX]

cool yes, finally :)

thank you, merging now then