-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loosen version requirement #15
Conversation
Right now this is giving an error on installation: ``` ERROR: pytest-markdown-docs 0.4.1 has requirement markdown-it-py<1.2.0,>=1.1.0, but you'll have markdown-it-py 3.0.0 which is incompatible. ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-approved 👍. This diff qualified for automatic approval and doesn't need follow up review.
Strange, I don't think we have any transitive 3.0.0 dependencies. 2.2.0 should satisfy all of our dependencies as far as I can tell, but maybe some of our dependencies changed their sub-deps, and pip does work in weird ways sometimes... I haven't tested it with 3.0.0, but if it seems to work then I think we can bump. But perhaps with an upper bound to make sure it doesn't randomly break in the future? Relatedly - we should bump the main repo pytest-markdown-docs dependency to 0.4.3 |
The problem is that I'll upper bound it by 4.0 perhaps |
Wait what's the difference between |
Sorry, let me fix my comment! Typo. I realize I just made it even more confusing. |
Hey, I'm still getting this error on modal-labs installation for
I'm going to go ahead and merge it if it's okay. The PR doesn't break anything, and I can still run markdown docs fine with my version 3.0 of markdown-it-py. |
Right now this is giving an error on installation: