Allow fixtures to override values of globals and other fixtures #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prbot approve |
![modal-pr-review-automation[bot]](https://avatars.githubusercontent.com/in/335990?s=60&v=4){kind=small}
mwaskom
approved these changes
Sep 23, 2024
mwaskom
reviewed
Oct 15, 2024
| @@ -69,8 +69,7 @@ def runtest(self): | |||
| # Since these are not actual functions with arguments, the only | |||
| # arguments that should appear in self.funcargs are the filled fixtures | |||
| for argname, value in self.funcargs.items(): | |||
| if argname not in all_globals: | |||
| all_globals[argname] = value | |||
| all_globals[argname] = value | |||
There was a problem hiding this comment.
Naive question as I haven't read much of the context but will this update persist / leak to other tests? Should we initialize all_globals from a copy of the mod.__dict__ instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also some dependency flexibility