Skip to content

ci: Skip Deploy workflow on forks #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

jajik
Copy link
Contributor

@jajik jajik commented Oct 14, 2024

It's annoying that the CI fails in forks for Deploy job. This change prevents the job from running in forks.

@jajik jajik requested a review from rhusar October 14, 2024 10:25
@jajik jajik added enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels Oct 14, 2024
@rhusar
Copy link
Member

rhusar commented Oct 14, 2024

I am not seeing that issue in my fork:

https://github.com/rhusar/docs.modcluster.io/actions/runs/11323772182/job/31487132172

Did you make a shallow copy accidentally when forking and that's why it's failing since you are missing the correct branch?

Copy link
Member

@rhusar rhusar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having said that - it's still a waste of resources. LGTM

@rhusar rhusar merged commit 8e8a4b4 into modcluster:main Oct 14, 2024
1 check passed
@rhusar
Copy link
Member

rhusar commented Oct 14, 2024

Thanks @jajik

@jajik jajik deleted the deploy-fix branch October 14, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants