ci: Use built docs in Deploy job, use single file

[jajik]

The deployment can use the ci artifact directly instead of building again (it needs to be in the same file, but that seems like an acceptable change).

[rhusar]

Good idea, the price we pay is this ugliness on every PR:

[jajik]

That's fine by me 🤷‍♂️ (I'm more concerned with the ugly if in the .yml file 😄 but I won't look at it unless something breaks or so...)

[rhusar]

Ironically, I have been trying to move away from having a single workflow for PR and upstream/main since they have different scopes (deploy, publish snapshot, publis javadoc, etc).

This will also break the icon in README and the link (https://github.com/modcluster/docs.modcluster.io/actions/workflows/deploy.yml) but I will fix that.

[rhusar]

Let's try this!

[rhusar]

Ironically, I have been trying to move away from having a single workflow for PR and upstream/main since they have different scopes (deploy, publish snapshot, publis javadoc, etc).

This will also break the icon in README and the link (https://github.com/modcluster/docs.modcluster.io/actions/workflows/deploy.yml) but I will fix that.

Fixed the link - bffc3ed

[rhusar]

@jajik Are you sure this works? because it doesn't - https://github.com/modcluster/docs.modcluster.io/actions/runs/11328040976

[jajik]

Well, I wanted to preserve the deploy.yml file, but it is required to have one action without dependencies in each file...

[rhusar]

I think you misunderstood what 'needs' actually does in GHA..

[jajik]

Nope, the checkout is missing because I did not realize the gh-pages stuff needs that.

[jajik]

I'll fix it after a meeting

[rhusar]

Nope, the checkout is missing because I did not realize the gh-pages stuff needs that.

Right - the 'deploy' job just doesn't have the checkout nor nothing else from the 'ci' job for that matter..