Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testsuite: investigate usage of portOffset rather than seding the ports #140

Closed
rhusar opened this issue Aug 30, 2023 · 2 comments · Fixed by #157
Closed

Testsuite: investigate usage of portOffset rather than seding the ports #140

rhusar opened this issue Aug 30, 2023 · 2 comments · Fixed by #157
Assignees

Comments

@rhusar
Copy link
Member

rhusar commented Aug 30, 2023

Perhaps that would simplify things.

Context: #137 (comment)

@jajik
Copy link
Collaborator

jajik commented Aug 31, 2023

There are multiple things:

  • Function tomcat_start that allows us to set various ports.
    • Here we could use portOffset feature instead of our manual offsetting.
    • That might interfere with the ability to set ports manually – can we easily apply the offset for some ports only?
      • update: Yes, it possible to add an offset to only some ports (it's done for each Connector in server.xml separately).
  • Part of the tomcat docker image script that tries to find an empty shutdown port (here).
    • We want to drop this probably (i.e., drop this section + check testsuite for tomcat_shutdown_port=yes and set it explicitly or use the mechanism above).

@jajik
Copy link
Collaborator

jajik commented Sep 25, 2023

I can confirm that portOffset would simplify things. Although, it would be possible to preserve our ability to set ports manually, after going through our test base I would say it is not necessary. I'll prepare a PR once MODCLUSTER-798 gets resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants