Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Use portOffset in Tomcat containers #157

Merged
merged 3 commits into from
Dec 21, 2023
Merged

tests: Use portOffset in Tomcat containers #157

merged 3 commits into from
Dec 21, 2023

Conversation

jajik
Copy link
Collaborator

@jajik jajik commented Oct 23, 2023

close #140

@jajik jajik self-assigned this Oct 23, 2023
@rhusar
Copy link
Member

rhusar commented Dec 12, 2023

Passing now, great! Thanks for verifying the fix. Opening for review.

@rhusar rhusar marked this pull request as ready for review December 12, 2023 18:11
@rhusar rhusar merged commit de77979 into modcluster:main Dec 21, 2023
8 checks passed
@rhusar
Copy link
Member

rhusar commented Dec 21, 2023

Thanks @jajik

@jajik jajik deleted the issue-140 branch January 16, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhusar rhusar rhusar approved these changes

Assignees

@jajik jajik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testsuite: investigate usage of portOffset rather than seding the ports
2 participants
@jajik @rhusar