Require Alias and Context for *-APP commands #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converting to draft because it does make sense to have some APP commands global... have to sort it out... |
jajik
force-pushed
the
MODCLUSTER-832
branch
3 times, most recently
from
d80bab6
to
ecbbd06
Compare
|
For the wildcarded APP commands we allow no Context and Alias, otherwise we require it. |
rhusar
requested changes
Oct 11, 2024
|
@jajik Can you remind me what are the implications of mod_proxy_cluster creating an empty Virtual Host (with empty Context and Alias)? |
I'm not sure now, but the current behaviour is equivalent to |
jfclere
approved these changes
Oct 24, 2024
|
@rhusar could you please remove your changes requested if there is nothing else? |
rhusar
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/MODCLUSTER-832