fix: resolve package.json import error in CLI build #836
+35
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add prebuild script to extract package info to src/pkgInfo.json - Update import to use generated pkgInfo.json instead of ../package.json - Add dev script for local CLI testing - Create CLI README with development examples - Add pkgInfo.json to .gitignore Fixes modelcontextprotocol#834
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix package.json import error in CLI build that caused module resolution failure in production
Motivation and Context
The CLI was failing in production builds with "Cannot find module '../package.json'" error because the relative import path didn't resolve correctly from the compiled JavaScript in the build directory. This prevented the CLI from working when installed via npm/npx.
How Has This Been Tested?
npm run devscript for local developmentBreaking Changes
None. This is a build-time fix that doesn't change the CLI's public API or behavior.
Types of changes
Checklist
Additional context
jqto extract only needed package fields (version, name, description)pkgInfo.jsonto .gitignore to prevent committing generated filesFixes #834