Skip to content

Commit

Permalink
Use windowsHide because detached seems to break stdio redirection on npx
Browse files Browse the repository at this point in the history
  • Loading branch information
anaisbetts committed Nov 26, 2024
1 parent 8f89fb2 commit 9fd52c8
Showing 1 changed file with 3 additions and 12 deletions.
15 changes: 3 additions & 12 deletions src/client/stdio.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export class StdioClientTransport implements Transport {
async start(): Promise<void> {
if (this._process) {
throw new Error(
"StdioClientTransport already started! If using Client class, note that connect() calls start() automatically.",
"StdioClientTransport already started! If using Client class, note that connect() calls start() automatically."
);
}

Expand All @@ -113,17 +113,8 @@ export class StdioClientTransport implements Transport {
stdio: ["pipe", "pipe", this._serverParams.stderr ?? "inherit"],
shell: false,
signal: this._abortController.signal,

// NB: The behavior of detached varies based on platform, and also
// is different based on whether the process is a Win32 Subsystem
// process or a Console Subsystem process. Strangely, the behavior
// of detached is almost 1:1 the opposite in Electron+Windows vs
// what is documented on the node.js website, and also is different
// based on whether you launch Electron in a development environment
// (i.e. via `electron-forge start`) vs a production environment
// (i.e. YourApp.exe).
detached: process.platform === "win32" && isElectron(),
},
windowsHide: process.platform === "win32" && isElectron(),
}
);

this._process.on("error", (error) => {
Expand Down

0 comments on commit 9fd52c8

Please sign in to comment.