Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add cjs format support #110

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: add cjs format support #110

wants to merge 6 commits into from

Conversation

ycjcl868
Copy link

@ycjcl868 ycjcl868 commented Dec 31, 2024 •
edited
Loading

Close #90

image

jspahrsummers
jspahrsummers requested changes Jan 2, 2025
View reviewed changes
Copy link
Member

@jspahrsummers jspahrsummers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change appears to inline every file's imports into the output version of that file (CJS and ESM).

If you can fix that up—so that cross-file imports/requires work as expected—we can consider pulling this in.

If not, note that CJS support is not a priority for us.

@ycjcl868
Copy link
Author

ycjcl868 commented Jan 3, 2025

fix

I’ve updated the code. Please review it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jspahrsummers jspahrsummers jspahrsummers requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CommonJS Support
2 participants
@ycjcl868 @jspahrsummers