Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix schema definitions for RequestSchema #20

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

ashwin-ant
Copy link
Member

@ashwin-ant ashwin-ant commented Oct 16, 2024

Turns out Zod's .extend doesn't do a deep merge on fields, it's really just for adding/replacing fields. So in order for all requests to have the _meta.progressToken field, we need to explicitly extend the params field wherever we're adding params.

Copy link
Member

@jspahrsummers jspahrsummers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:ohno: but good catch!

@ashwin-ant ashwin-ant merged commit 7d70db8 into main Oct 17, 2024
3 checks passed
@ashwin-ant ashwin-ant deleted the ashwin/progress branch October 17, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants