Start replicated models based on version hash#2382
Conversation
Test Results 247 files 247 suites 50m 38s ⏱️ Results for commit fcae6cc. ♻️ This comment has been updated with latest results. |
abstraktor
force-pushed
the
feat/start-replicated-models-by-version-hash
branch
from
4e1dc75 to
ac48054
Compare
abstraktor
changed the base branch from
main
to
fix/reference-roles-in-inodejs
abstraktor
force-pushed
the
feat/start-replicated-models-by-version-hash
branch
3 times, most recently
from
edb7441 to
9ea7d6f
Compare
JVM coverage report
|
abstraktor
force-pushed
the
feat/start-replicated-models-by-version-hash
branch
from
9ea7d6f to
035cb2d
Compare
…nHash and repositoryId
abstraktor
force-pushed
the
feat/start-replicated-models-by-version-hash
branch
from
035cb2d to
fcae6cc
Compare
| } | ||
|
|
||
| override suspend fun poll(): CLVersion { | ||
| // let's pretent to do something. The version is actually immutable and won't ever change… |
There was a problem hiding this comment.
What's the point of using a ReplicatedModel that doesn't do any replication? Just load the version as a read-only model instead.
There was a problem hiding this comment.
Using a unified api: A user may or may not have permission to modify the document – we want to use the same api in both cases.
Also: We typically want to modify only one model and load one or more additional models as readonly libraries.
This felt like the easiest implementation – we can also consider generalizing ReplicatedModel though (ReplicatedModel and ReadonlyModel would implement an interface called …Model then?)…
2 participants
Changes