403 Response Handling and Token Refresh on Branch Change#2418
Draft
abstraktor wants to merge 1 commit intofeat/readonly-nodejsfrom
Draft
403 Response Handling and Token Refresh on Branch Change#2418abstraktor wants to merge 1 commit intofeat/readonly-nodejsfrom
abstraktor wants to merge 1 commit intofeat/readonly-nodejsfrom
Conversation
Contributor
Contributor
JVM coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
"Changing a branch should trigger reloading the token with the new permissions"
When a user switches to a different branch that requires different permissions, the server returns HTTP 403 Forbidden. The original code did not properly handle this scenario, potentially causing:
Solution
The fix implements proper 403 Forbidden response handling in ModelixAuthClient.kt
Alternatives
This ended up quite complex. We could consider making the auth token updatable and exposing a setter for it in the javascript client. Then we could prevent these 403s at all.