do not expose func file and line

modern-go · Mar 1, 2018 · 938152c · 938152c
1 parent b889e4d
commit 938152c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/unbounded_executor.go b/unbounded_executor.go
@@ -11,8 +11,8 @@ import (
 )
 
 // HandlePanic logs goroutine panic by default
-var HandlePanic = func(recovered interface{}, file string, line int, funcName string) {
-	ErrorLogger.Println(fmt.Sprintf("%s defined at %s:%v panic: %v", funcName, file, line, recovered))
+var HandlePanic = func(recovered interface{}, funcName string) {
+	ErrorLogger.Println(fmt.Sprintf("%s panic: %v", funcName, recovered))
 	ErrorLogger.Println(string(debug.Stack()))
 }
 
@@ -26,7 +26,7 @@ type UnboundedExecutor struct {
 	cancel                context.CancelFunc
 	activeGoroutinesMutex *sync.Mutex
 	activeGoroutines      map[string]int
-	HandlePanic           func(recovered interface{}, file string, line int, funcName string)
+	HandlePanic           func(recovered interface{}, funcName string)
 }
 
 // GlobalUnboundedExecutor has the life cycle of the program itself
@@ -64,9 +64,9 @@ func (executor *UnboundedExecutor) Go(handler func(ctx context.Context)) {
 			recovered := recover()
 			if recovered != nil && recovered != StopSignal {
 				if executor.HandlePanic == nil {
-					HandlePanic(recovered, file, line, funcName)
+					HandlePanic(recovered, funcName)
 				} else {
-					executor.HandlePanic(recovered, file, line, funcName)
+					executor.HandlePanic(recovered, funcName)
 				}
 			}
 			executor.activeGoroutinesMutex.Lock()

diff --git a/unbounded_executor_test.go b/unbounded_executor_test.go
@@ -39,7 +39,7 @@ func ExampleUnboundedExecutor_StopAndWaitForever() {
 }
 
 func ExampleUnboundedExecutor_Go_panic() {
-	concurrent.HandlePanic = func(recovered interface{}, file string, line int, funcName string) {
+	concurrent.HandlePanic = func(recovered interface{}, funcName string) {
 		fmt.Println(funcName)
 	}
 	executor := concurrent.NewUnboundedExecutor()