Ruby3, faraday2 compatibility, remove parse native collection override templates #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
“warning: Capturing the given block using Proc.new is deprecated; use `&block` instead”
Can't have two autoloaded files defining the same class. It results in inconsistent behavior. Built-in parse classes have to be properly reopened with class_eval.
|
Could you please review? |
apersaud
approved these changes
Jan 21, 2023
|
Faraday2 compatibility is not met while having faraday_middleware as a dependency (see deprecation warning here: https://github.com/lostisland/faraday_middleware) if another project dependency needs faraday2 you will find the following error while bundling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes to bring compatibility with ruby 3 and faraday 2. Remove parse native collections models override templates that don't work.