Feature: Basic PHP 8 Support #128
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, this can't even be installed on a project who's minimum requirement is PHP 8.0, this should allow that to happen while still locking packages in the PHP7.2 version, so it's not 100% guaranteed to work until we've completed full migrations.
However, this will at least allow it to be installed and tested on future PHP 8.x+ minimum requirements.
I'm going to test this to see what version this will come out as, as I don't think there are any backwards compatible issues at the moment, so it could even be considered a bug fix.Edit: Working just fine on our 7.4 systems, some deps don't work for PHP8.0 projects yet, but we'll address that down the road.