Skip to content

Being explicit in Meta_Map #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
szepeviktor wants to merge 7 commits into
base: 4.x
Choose a base branch
from
Open

Being explicit in Meta_Map #79

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9d8ca99
Being explicit in Meta_Map
szepeviktor Nov 10, 2020
bec35cf
prepare release
defunctl Aug 19, 2022
ebbf0fc
open 4.1-dev
defunctl Aug 19, 2022
1b2c4f4
Merge branch 'master' into patch-2
szepeviktor Mar 7, 2023
7ff31b9
Update src/Post_Meta/Meta_Map.php
szepeviktor Mar 8, 2023
d538042
Update Meta_Map.php
szepeviktor Mar 8, 2023
e26dfb6
Merge branch '4.x' into patch-2
szepeviktor Mar 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/Post_Meta/Meta_Map.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class Meta_Map {
*
* @phpstan-ignore-next-line
*/
private $post_type = '';
private $post_type;

/** @var Meta_Group[] */
private $keys = [];
Expand Down Expand Up @@ -55,9 +55,10 @@ public function get_keys() {
* @return mixed The value for the given key
*/
public function get_value( $post_id, $key ) {
if ( isset( $this->keys[ $key ] ) ) {
return $this->keys[ $key ]->get_value( $post_id, $key );
if ( ! array_key_exists( $key, $this->keys ) ) {
return null;
}
return null;

return $this->keys[ $key ]->get_value( $post_id, $key );
}
}